-
Notifications
You must be signed in to change notification settings - Fork 168
Adding real-world circulation models datasets #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding a circulation model dataset mimicking the layout of copernicusmarine
|
Just documenting what I see from a baroclinic gyre simulation with the MITgcm, when ingesting netcdf output with Xarray and XGCM For reference this was generated with the following code |
|
Thanks for sharing the MITgcm output, @fluidnumerics-joe. But since we're also interested in the metadata of each variable and coordinate, could you share the actual |
|
@erikvansebille - here's a trimmed down MITgcm dataset created with MITgcm's built-in netcdf io This can be read in with I'm creating the same output but in the native metadata format. That will arrive soon |
|
I've now added datasets mimicking the layout of NEMO (both C- and A-grid), Hycom, ECCO4, MITgcm, FES, ERA5, CESM (aka POP), GlobCurrent and CROCO. @VeckoTheGecko, I now realise that you also started #2014, which not only adds the datasets but also includes some other changes. Would it make sense to merge this PR with #2014 first? Or merge them both into v4-dev directly? |
It is an invalid argumnet to the rand() function
I don't think the dataset in that PR is that important to bring into here (this looks more fleshed out than that attempt) - but I think the tooling would be good to bring into here so I can work on that. |
And remove redundant docstring
Done |
|
@erikvansebille not sure if you already have - would it be worth using the new tooling ( |
|
No I haven't included any testing myself. Didn't realise you hadn't done it either. Can you add these tests (in a new PR)? |
|
There is testing in the sense of importing the datasets (which is good, so we know that the datasets construct). The tooling |
Ah, now I understand what you mean. I agree it's important to verify consistency. I'll do that on Monday when I'm back at my desk |
|
Here's the same MITgcm dataset in MDS format It can be read using Output looks like Note the difference in the coordinates. Additionally, notice that |


Adding circulation model dataset mimicking the layout of real-world hydrodynamic models
mainfor v3 changes,v4-devfor v4 changes)