Skip to content

Removing grid.py and time_origin for v4 #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erikvansebille merged 5 commits into from
Jul 8, 2025
Merged

Removing grid.py and time_origin for v4 #2068

erikvansebille merged 5 commits into from
Jul 8, 2025

Conversation

@erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Jul 3, 2025 •
edited
Loading

As time will become a np.datetime64/np.timedelta64 object, no need anymore for time_origin and TimeConverter. This PR removes them.

It also removes the old grid.py

  • Chose the correct base branch (main for v3 changes, v4-dev for v4 changes)

@erikvansebille
Removing time_origin for v4
4cc5d0a 
As time will become a datetime64?timedelta64 object, no need anymore for time_origin and TimeConverter
@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Jul 4, 2025

Before we can merge this, I think we need to also get rid of the old grid class entirely (its not used anymore - was just keeping it for reference, but we're passed that stage now). I'll work on it today

@erikvansebille
Copy link
Member Author

erikvansebille commented Jul 4, 2025

Oh I can also do that; was actually planning on doing this the coming few days (hence the draft status of this PR). I'm getting pretty good at removing old code ;-)

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Jul 4, 2025

Cool, sounds good. It will require removing test_xgrid_against_old in tests/v4/test_xgrid.py - but that should be the only change required in the v4 test suite.

@VeckoTheGecko VeckoTheGecko mentioned this pull request Jun 24, 2025
Open
24 tasks
Base automatically changed from minimal-v4-particleset to v4-dev July 7, 2025 14:28
@erikvansebille erikvansebille changed the title Removing time_origin for v4 Removing grid.py and time_origin for v4 Jul 8, 2025
@erikvansebille erikvansebille marked this pull request as ready for review July 8, 2025 06:08
VeckoTheGecko
VeckoTheGecko requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some further removal of code then I think we're good to go!

@github-project-automation github-project-automation bot moved this from Backlog to Ready in Parcels development Jul 8, 2025
@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Jul 8, 2025

image
🤩

@erikvansebille erikvansebille merged commit 73e0487 into v4-dev Jul 8, 2025
8 of 9 checks passed
@erikvansebille erikvansebille deleted the remove_time_origin branch July 8, 2025 08:42
@github-project-automation github-project-automation bot moved this from Ready to Done in Parcels development Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeckoTheGecko VeckoTheGecko VeckoTheGecko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Parcels development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikvansebille @VeckoTheGecko