Removing _nextloop particle variables#2212
Merged
erikvansebille merged 2 commits intov4-devfrom Sep 15, 2025
Merged
Conversation
As they are not necessary anymore. However, we are keeping time_nextloop for now because we can't initialise particles.dt=0 (meaning particles.time would be already increased in the Setcoords Kernel)
VeckoTheGecko
approved these changes
Sep 15, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
This looks good. Saw the draft status - anything stopping us from merging is and looking at time_nextloop another time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
particles.lon_nextloop,particles.lat_nextloopandparticles.depth_nextloopas they are not necessary anymore, now that thedlonis stored as aVariableon theparticles.However, I'm afraid we do need to keep the
particle.time_nextloopfor now because we can't initialiseparticles.dt=0, meaningparticles.timewould be already increased in theSetcoordsKernel. This would result in time and location being mismatched. I'll dig a bit deeper and hopefully find a clean solution