Adding lonlatdepth_dtype argument to ParticleSet constructor methods too #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :param repeatdt: Optional interval (in seconds) on which to repeat the release of the ParticleSet | ||
| :param lonlatdepth_dtype: Floating precision for lon, lat, depth particle coordinates. | ||
| It is either np.float32 or np.float64. Default is np.float32 if fieldset.U.interp_method is 'linear' | ||
| and np.float64 if the interpolation method is 'cgrid_velocity' |
Contributor
There was a problem hiding this comment.
Do we want all those changes?
I thought we could simply set lonlatdepth_dtype through the **kwargs.
(but they were missing in from_line)
So both methods are obviously valid, but I don't know what's the most common one. And if the param is not in the argument list, then should it be in the docstring, or only in the docstring of pset constructor? Let's have a look how such parameters usually work)
parcels/particleset.py
Outdated
| and np.float64 if the interpolation method is 'cgrid_velocity' | ||
| """ | ||
|
|
||
| lonlat_type = cls.lonlatdepth_dtype_from_field_interp_method(fieldset.U) |
Contributor
There was a problem hiding this comment.
if lonlatdepth_type is defined, it should overwrite the default value of lonlat_type
delandmeterp
approved these changes
Apr 17, 2019
erikvansebille
deleted the
lonlatdepth_dtype_in_particleset_construction_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #552