Fixing gcc C-standard to prevent compile failure with newer compiler versions #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gcc 7.5.0 and gcc 8.4.0 in C-standard
1 task
1 task
erikvansebille
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details see @VictorOnink 's initial error report in #941
Gist: compiling the JIT sources (specifically: parcels.h) with newer gcc-versions or their derivatives - as provided by the
anacondaconda channel instead of theconda-forgeconda channel - fails, complaining that hiding function calls inside macro's is invalid. That statement is incorrect for C11, but it is correct for C17 as C17 is more pedantic than previous versions.This PR fixed the issue by specifying the C-standard to be
-std=gnu11in the C-compiler parameter class. We can fix it here because normal C-standards (C89, C99, C11, C17) and newer GNU-dialects (GNU17) fail compilation. Those fails can be fixed, but it will take significant re-work as thenM_PIand other constants need to be removed or replaced.Hence, we hereby define that OceanParcels uses exclusively GNU-11 compile standards.