-
Notifications
You must be signed in to change notification settings - Fork 10
Update to copernicusmarine v2.2.2 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests are failing with: It's to do with depreciation in the seabird package, which is only used for testing the added noise in test_ctd_make_realistic.py. However, the added noise procedure is currently not implemented in VirtualShip. Can we remove this test for the time being? And re-add it should we add the noise back in down the line? Commenting it out is a temporary option... cc @ammedd |
|
Yes, please do comment out the seabird package for now. We'll add it later indeed. It requires a bit of thinking/discussing on our side. |
| # def test_ctd_make_realistic(tmpdir) -> None: | ||
| # # add noise and convert to cnv | ||
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would either add a TODO comment with reference to the GitHub Issue if we expect the package to be back online later; or completely remove (instead of comment out) seabird when we don't expect it to be useable anytime in the future
| # def test_ctd_make_realistic(tmpdir) -> None: | |
| # # add noise and convert to cnv | |
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") | |
| # TODO readable this test when seabird package works again (see #200) | |
| # def test_ctd_make_realistic(tmpdir) -> None: | |
| # # add noise and convert to cnv | |
| # files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Seabird doesn't not appear very active so I have removed it, and added a TODO for future reference.
Updated copernicusmarine dependency to v2.2.2, which fixes the bug raised in #198.
virtualship fetchis now working again!