Skip to content

Conversation

@j-atkins
Copy link
Collaborator

Updated copernicusmarine dependency to v2.2.2, which fixes the bug raised in #198.

virtualship fetch is now working again!

@j-atkins
Copy link
Collaborator Author

j-atkins commented Aug 27, 2025

Tests are failing with:

================================= short test summary info =================================
ERROR tests/make_realistic/test_ctd_make_realistic.py - UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/...
!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!
==================================== 1 error in 1.72s =====================================

It's to do with depreciation in the seabird package, which is only used for testing the added noise in test_ctd_make_realistic.py. However, the added noise procedure is currently not implemented in VirtualShip.

Can we remove this test for the time being? And re-add it should we add the noise back in down the line? Commenting it out is a temporary option...

cc @ammedd

@ammedd
Copy link
Collaborator

ammedd commented Aug 27, 2025

Yes, please do comment out the seabird package for now. We'll add it later indeed. It requires a bit of thinking/discussing on our side.

@j-atkins j-atkins requested review from VeckoTheGecko, ammedd and erikvansebille and removed request for VeckoTheGecko August 27, 2025 12:52
Comment on lines 6 to 8
# def test_ctd_make_realistic(tmpdir) -> None:
# # add noise and convert to cnv
# files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would either add a TODO comment with reference to the GitHub Issue if we expect the package to be back online later; or completely remove (instead of comment out) seabird when we don't expect it to be useable anytime in the future

Suggested change
# def test_ctd_make_realistic(tmpdir) -> None:
# # add noise and convert to cnv
# files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_")
# TODO readable this test when seabird package works again (see #200)
# def test_ctd_make_realistic(tmpdir) -> None:
# # add noise and convert to cnv
# files = ctd_make_realistic("ctd.zarr", out_dir=tmpdir, prefix="CTD_")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Seabird doesn't not appear very active so I have removed it, and added a TODO for future reference.

@j-atkins j-atkins merged commit 6d915c7 into main Aug 27, 2025
9 of 11 checks passed
@j-atkins j-atkins deleted the cm-bug-fix branch August 27, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants