virtual_ship package #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvansebille
approved these changes
Apr 15, 2024
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Good package structure, see a few suggestions and a question below
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Contributor
Author
|
Emma will first push the final code she still had locally on her computer. Then I will rearrange this pr. |
Collaborator
|
Go ahead with the PR, I'll add things as issues |
ammedd
requested changes
Apr 16, 2024
ammedd
approved these changes
Apr 16, 2024
erikvansebille
approved these changes
Apr 16, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
- Packaged code in virtual_ship package - Created pyproject.toml for project - Made tiny changes to code that were still on Emma's computer and not on github
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
- Packaged code in virtual_ship package - Created pyproject.toml for project - Made tiny changes to code that were still on Emma's computer and not on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just a first iteration, we will package and organize the code more thoroughly later.
@ammedd I left open the project description in the toml file for you to create.