Argo floats in shallow waters #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto shallow-argos
for more information, see https://pre-commit.ci
erikvansebille
approved these changes
Dec 8, 2025
| name=out_path, | ||
| outputdt=OUTPUT_DT, | ||
| chunks=[len(argo_float_particleset), 100], | ||
| chunks=[len(argo_float_particleset), 100], # TODO: is this necessary? |
Member
There was a problem hiding this comment.
Otherwise, the output is very slow (because each observation is its own chunk). So I recommend keeping this yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces behaviour to the Argo float vertical movement kernel to avoid grounding on the seafloor in waters shallower than the typical Argo drifting depth (1000m) and max depth (2000m), following on from #262.
Previously, if a drifter was deployed in shallow waters an Argo in VirtualShip would artificially continue descending to beneath the sea floor as it tried to reach its drift depth or max depth for sampling. To illustrate the point, I have mocked up an Argo deployment around the Norwegian sea: see this 3D plot
this 3D plot HTML file with the trajectory + bathymetry map. It is also not advecting properly at the artificial depths.
Logic is now added to the
_argo_float_vertical_movementkernel whereby if the particle reaches the seafloor it will stop descending and add 50m onto the particle depth. This is similar to how VirtualFleet opt to mimic real-life Argo behaviour. Now, repeating the same shelf-break deployment as above, the Argo will drift above the seafloor: see the updated 3D plot HTML file.If the deployment location is < 50m depth then an error is thrown indicating that Argos cannot be deployed in such shallow waters.
Note: I have arranged a meeting with the Argo team next week to further discuss realistic Argo behaviours. So, this may be subject to change in a future PR but the basis for dealing with seafloor grounding is established in the current PR.