Ship underwater st test #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
surgura
commented
Jun 5, 2024
surgura
commented
- Implemented test for ship underwater st. Other tests will follow, but let's review this one so we agree on how to test.
- Refactored and made ship underwater st work so it passes the test
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks like a good and useful test flow. See some comments below
erikvansebille
approved these changes
Jun 10, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
* Implemented test for ship underwater st. Other tests will follow, but let's review this one so we agree on how to test. * Refactored and made ship underwater st work so it passes the test
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Implemented test for ship underwater st. Other tests will follow, but let's review this one so we agree on how to test. * Refactored and made ship underwater st work so it passes the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.