Ctd cleanup and test #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| lat = [ctd.spacetime.location.lat for ctd in ctds] | ||
| time = [ctd.spacetime.time for ctd in ctds] | ||
| WINCH_SPEED = 1.0 # sink and rise speed in m/s | ||
| DT = 10.0 # dt of CTD simulation integrator |
Member
There was a problem hiding this comment.
Why is this variable in capitals? We normally use lowercase for dt
Contributor
Author
There was a problem hiding this comment.
it is a constant, and in PEP8 constants have to be all caps
erikvansebille
approved these changes
Jul 15, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
Cleaned up CTD
Wrote test for CTD
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
Cleaned up CTD
Wrote test for CTD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields varying with time are not tested, as it's quite tricky to predict the expected observations.
There is also an issue currently, where the simulation always goes over the complete fieldset. Have to check if we can tall Parcels to stop simulating when all particles are done, and maybe skip over parts where no particles have been deployed yet.