Skip to content

Make test_drifter more complex by deploying non-overlapping times #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surgura merged 3 commits into from
Jul 30, 2024
Merged

Make test_drifter more complex by deploying non-overlapping times #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cad67c4
Make test_drifter more complex by deploying non-overlapping times
erikvansebille Jul 30, 2024
7e3a3cc
Removing empty line at end of file
erikvansebille Jul 30, 2024
0fa0cb9
codetools fixes
surgura Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions tests/instruments/test_drifter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def test_simulate_drifters(tmpdir: py.path.LocalPath) -> None:
"lat": np.array([0.0, 10.0]),
"time": [
np.datetime64(base_time + datetime.timedelta(seconds=0)),
np.datetime64(base_time + datetime.timedelta(hours=4)),
np.datetime64(base_time + datetime.timedelta(days=3)),
],
},
)
Expand All @@ -47,7 +47,7 @@ def test_simulate_drifters(tmpdir: py.path.LocalPath) -> None:
Drifter(
spacetime=Spacetime(
location=Location(latitude=1, longitude=1),
time=base_time + datetime.timedelta(hours=1),
time=base_time + datetime.timedelta(hours=20),
),
depth=0.0,
lifetime=None,
Expand All @@ -74,13 +74,15 @@ def test_simulate_drifters(tmpdir: py.path.LocalPath) -> None:
for drifter_i, traj in enumerate(results.trajectory):
# Check if drifters are moving
# lat, lon, should be increasing values (with the above positive VU fieldset)
dlat = np.diff(results.sel(trajectory=traj)["lat"].values)
assert np.all(
np.diff(results.sel(trajectory=traj)["lat"].values) > 0
dlat[np.isfinite(dlat)] > 0
), f"Drifter is not moving over y {drifter_i=}"
dlon = np.diff(results.sel(trajectory=traj)["lon"].values)
assert np.all(
np.diff(results.sel(trajectory=traj)["lon"].values) > 0
), f"Drifter is not mvoing over x {drifter_i=}"

dlon[np.isfinite(dlon)] > 0
), f"Drifter is not moving over x {drifter_i=}"
temp = results.sel(trajectory=traj)["temperature"].values
assert np.all(
results.sel(trajectory=traj)["temperature"] == CONST_TEMPERATURE
temp[np.isfinite(temp)] == CONST_TEMPERATURE
), f"measured temperature does not match {drifter_i=}"