Sail by waypoint #46
Merged
Sail by waypoint #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Simulate the sailing and aggregate what measurements should be simulated. | ||
| :param waypoints: The schedule. | ||
| :param projection: Projection used to sail between waypoints. |
Member
There was a problem hiding this comment.
Also mention what the default is?
Contributor
Author
There was a problem hiding this comment.
I am not sure what you mean? this function does not provide a default?
Member
There was a problem hiding this comment.
Well, I think the default is pyproj.Geod(ellps="WGS84")? Mention that here in the docstring?
Contributor
Author
There was a problem hiding this comment.
This function itself does not provide a default. The projection is passed when called the function. You might be referring to the sailship function, which indeed uses that projection.
erikvansebille
approved these changes
Aug 6, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.