Skip to content

Conversation

@surgura
Copy link
Contributor

@surgura surgura commented Aug 10, 2024

#30 for CTD only

@surgura
Copy link
Contributor Author

surgura commented Aug 10, 2024

Sorry for the one million files in the test zarr. I could also generate that on the fly instead of saving? maybe that's beter, not sure

@erikvansebille
Copy link
Member

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?

Oh, and should the CNV is the title of this PR not be CSV?

@surgura
Copy link
Contributor Author

surgura commented Aug 12, 2024

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?

Oh, and should the CNV is the title of this PR not be CSV?

The file format is CNV, a file format created by Seabird(the microcat brand)
The zarr file is in the test directory and used for the test. There already is a test for the creation of the zarr so that is not needed. I can either create it before running the rest by using the ctd function, but I think it might be better to replace this huge file with a very short zarr. That way a we have a fast test without having too much data on git

@erikvansebille
Copy link
Member

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

@surgura
Copy link
Contributor Author

surgura commented Aug 12, 2024

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

Ok makes sense I will keep that in mind. I have create a very small one now and I think this should be fine as test input?

surgura and others added 3 commits August 13, 2024 14:57
@surgura surgura requested a review from erikvansebille August 13, 2024 13:46
@surgura surgura merged commit 947e7d0 into development Aug 13, 2024
@surgura surgura deleted the ctd_noise branch August 13, 2024 14:51
surgura added a commit that referenced this pull request Aug 18, 2024
VeckoTheGecko pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants