Skip to content

53 interactive loop #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VeckoTheGecko merged 35 commits into from
Sep 25, 2024
Merged

53 interactive loop #60

VeckoTheGecko merged 35 commits into from
Sep 25, 2024

Conversation

@surgura
Copy link
Contributor

@surgura surgura commented Aug 23, 2024 •
edited by VeckoTheGecko
Loading

Sorry this is so large, changes are quite intertwined.

  • CLI tool for running expedition (formerly 'cruise')
  • Rewrote schedule simulation to be much simpler
  • If schedule simulation fails, a checkpoint is created and the user is told to update the schedule and run the tool again, which will resume from the checkpoint.
  • Seperated ship configuration and schedule (formerly 'waypoints') into two seperate files with improved loading checks
  • One waypoints can have multiple measurements done in parallel
  • Fixed some minor bugs that surfaced during creation of new tests

Related to #53

ammedd
ammedd reviewed Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@ammedd ammedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of changes. Functionality looks good in general, but some things are unclear to me

@surgura surgura requested a review from ammedd August 25, 2024 15:38
erikvansebille
erikvansebille reviewed Aug 26, 2024
View reviewed changes
@surgura surgura requested a review from erikvansebille August 26, 2024 17:36
erikvansebille
erikvansebille reviewed Aug 27, 2024
View reviewed changes
VeckoTheGecko and others added 2 commits September 25, 2024 13:54
@VeckoTheGecko @erikvansebille
Update virtual_ship/expedition/input_data.py
b1b31d9 
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
@VeckoTheGecko
patch test
00df77a
@VeckoTheGecko VeckoTheGecko merged commit 842ae2f into development Sep 25, 2024
@VeckoTheGecko VeckoTheGecko deleted the 53-interactive-loop branch September 25, 2024 13:08
VeckoTheGecko added a commit that referenced this pull request Sep 25, 2024
@surgura @erikvansebille @VeckoTheGecko
interactive loop (#60)
df3419b 
---------

Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
@VeckoTheGecko VeckoTheGecko mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikvansebille erikvansebille erikvansebille left review comments

@VeckoTheGecko VeckoTheGecko VeckoTheGecko approved these changes

@ammedd ammedd Awaiting requested review from ammedd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@surgura @erikvansebille @VeckoTheGecko @ammedd