Skip to content

Conversation

@VeckoTheGecko
Copy link
Collaborator

@VeckoTheGecko VeckoTheGecko commented Oct 21, 2024

Fixes #67

Changes:

  • Add virtualship init command
  • link to oceanparcels.org in docs sidebar
  • add README badges and link to repo
  • Fixes:
    • fix documentation config
    • remove meta.yml (managed by the feedstock)

Good to know

virtualship now comes with a virtualship.static folder which is used to store static files (e.g., example configuration .yml files). For data files (which are larger, and aren't as core to the functionality of virtualship) shouldn't be put here but instead should be downloaded on demand.

virtualship.utils contains a bunch of utilities for virtualship, including convenience functions for reading these static files

@VeckoTheGecko VeckoTheGecko changed the title Add init command and other fixes Add init command Oct 21, 2024
@VeckoTheGecko
Copy link
Collaborator Author

Static files aren't being packaged properly despite working locally. Removing the --no-build-isolation flag would fix it, but I'm not 100% sure if that's the right fix. Waiting on reponse in pypa/setuptools#4694

@VeckoTheGecko
Copy link
Collaborator Author

Decided to just remove the flag --no-build-isolation

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@05d4fbd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/virtualship/expedition/do_expedition.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage        ?   83.06%           
=======================================
  Files           ?       27           
  Lines           ?      856           
  Branches        ?        0           
=======================================
  Hits            ?      711           
  Misses          ?      145           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VeckoTheGecko VeckoTheGecko merged commit 8cdf931 into main Oct 21, 2024
@VeckoTheGecko VeckoTheGecko deleted the v/conf-gen branch October 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: Generate template config

4 participants