Add Argo tutorial #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Merge branch 'education' of https://github.com/OceanParcels/virtualship into education
for more information, see https://pre-commit.ci
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good in principle. But why not use the VirtualShip Argo capabilities here? Why keep with the raw Parcels version? Is that intentional?
Below some specific comments
- Why is the Research_proposal_only.ipynb file also part of this PR? Was that not a different PR?
- Provide some information on the region of the data at the beginning? Mention that this is in the Tropical Atlantic (just off the coast of Brazil?)
- The double quotes in the italic Notes before the ParticleClass and execute cells don't parse well. Make them single quotes?
- Add a markdown cell at the end with some questions to prompt readers to interpret what they see?
Collaborator
Author
|
Superseded by #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a tutorial based on Parcels for people to learn about "programming" the Argo floats.