Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use temporary names while creating *par2 files #84

Open
sdettmer opened this issue Jan 4, 2017 · 0 comments
Open

Use temporary names while creating *par2 files #84

sdettmer opened this issue Jan 4, 2017 · 0 comments
Milestone
0.8.0

Comments

@sdettmer
Copy link
Contributor

sdettmer commented Jan 4, 2017

When par2 is aborted during a longer creation operation, for example

Opening: 0001.mts
Computing Reed Solomon matrix.
Constructing: done.
Wrote 16776960 bytes to disk
Processing: 74.8%

If interrupted or aborted at this point, "invalid" par2 files were created. They seem not to contain any blocks, even if the file size might be non-zero:

Loading "0001.par2".
No new packets found
...
Main packet not found.

I think it could be great if the par2 files use a temporary name during creation, what do you think?
@BlackIkeEagle BlackIkeEagle added this to the 0.8.0 milestone Mar 16, 2017
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Aug 26, 2024
sysutils/bup: Update to 0.33.4
6998bc4 
Notable changes in 0.33.4 since 0.33.3 (incomplete)
===================================================

May require attention
---------------------

* The `par2` command (invoked by `bup fsck -g`) may generate empty
  recovery files if interrupted (say via C-c).  To mitigate this, bup
  now runs `par2` in a temporary directory, and only moves the
  recovery files into place if the generation succeeds.  It will also
  look for any empty par2 files, or incomplete sets, associated with
  packfiles that it has been asked to examine.  If found, they will
  provoke an error.  See also
  Parchive/par2cmdline#84

* Previously, any `bup on REMOTE ...` commands that attempted to read
  from standard input (for example `bup on HOST split < something` or
  `bup on HOST split --git-ids ...`) would read nothing instead of the
  original content of standard input.  Now those commands will either
  reject the invocation, or just crash when they attempt to read a
  closed stream.

* When building bup, if your version of GNU make is not named `make`,
  prefer invoking it directly (e.g. `gmake -j4 check`) instead of
  relying on the ./Makefile to redirect to GNU make.  Some non-GNU
  makes now break this redirection.  For example, if you include a
  `-j` option in your build command one of them adds a `-J` to
  `MAKEFLAGS` that GNU make rejects.  In future releases, we're likely
  to drop the redirection entirely.

Bugs
----

* `bup-config(5)` has been added, and mentions that at the moment `bup
  on REMOTE ...` incorrectly reads the `pack.packSizeLimit` from the
  `REMOTE` repository.

* `bup fsck` no longer requires a repository via `BUP_DIR`, `-d`,
  etc. when paths are provided on the command line.

Thanks to (at least)
====================

Ed Maste, Greg Troxel, Johannes Berg, and Rob Browning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@BlackIkeEagle @sdettmer