Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI: Rm use of deprecated actions #282

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jul 22, 2023

Fixed #280 and fixed #279

also:

  • Bump actions/checkout to v4
  • use taiki-e/install-action to install any binary crates
  • use Swatinem/rust-cache@v2 for caching
  • use strategy to avoid similar/duplicate jobs
  • pass --no-deps to cargo-clippy
  • Use cargo-nextest for randomize-layout
  • Run doc test in job test
  • Use cargo-nextest to speedup miri
  • Run cargo-check instead of cross-build in nostd.yml since
    there's no need for cross

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu NobodyXu force-pushed the remove-deprecated-actions branch 3 times, most recently from 371d78a to e7ad4b6 Compare July 22, 2023 14:31
@NobodyXu
Copy link
Contributor Author

The CI failure is an ICE reported here rust-lang/rust#113941 and seems to be already fixed.

@NobodyXu
Copy link
Contributor Author

The Linux PowerPC Big Endian 32-bit seems to be something else:

  process didn't exit successfully: `/linux-runner powerpc /target/powerpc-unknown-linux-gnu/release/deps/compact_str-55f75cb7fb8ff60b` (signal: 4, SIGILL: illegal instruction)
test repr::capacity::tests::test_all_valid_32bit_values ... 
Error: Process completed with exit code 101.

though I don't think is related to this PR.

@ParkMyCar
Copy link
Owner

Thanks for the PR @NobodyXu! I'm going to circle back to this one, I need to take a holistic look at CI and improve it's stability. I've also thought about moving over to Buildkite ... 🤔

@NobodyXu NobodyXu force-pushed the remove-deprecated-actions branch 8 times, most recently from 0a3b914 to 77d5805 Compare October 15, 2023 01:15
also:
 - Bump `actions/checkout` to v4
 - use `taiki-e/install-action` to install any binary crates
 - use `Swatinem/rust-cache@v2` for caching
 - use `strategy` to avoid similar/duplicate jobs
 - pass `--no-deps` to `cargo-clippy`
 - Use `cargo-nextest` for `randomize-layout`
 - Run doc test in job `test`
 - Use `cargo-nextest` to speedup `miri`
 - Run `cargo-check` instead of `cross-build` in `nostd.yml` since
   there's no need for `cross`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@ParkMyCar
Copy link
Owner

Oh geez, I really let this get stale, sorry about that @NobodyXu! Merging now, thank you for the improvements!

@ParkMyCar ParkMyCar merged commit 84eac94 into ParkMyCar:main Oct 25, 2023
@NobodyXu NobodyXu deleted the remove-deprecated-actions branch October 25, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzz Failure! 5630817545 Fuzz Failure! 5628044824
2 participants