Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline short static strings #321

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Inline short static strings #321

merged 1 commit into from
Oct 27, 2023

Conversation

Kijewski
Copy link
Contributor

@Kijewski Kijewski commented Oct 9, 2023

This way short static strings have better cache locality, too.

NobodyXu
NobodyXu approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Inline <= 12/24B to avoid redirection.

@NobodyXu
Copy link
Contributor

NobodyXu commented Oct 9, 2023

But looks like the CI needs more work

@ParkMyCar
Copy link
Owner

This looks good to me! Let's just get CI passing and then we can merge it

@Kijewski Kijewski mentioned this pull request Oct 12, 2023
Merged
@Kijewski
Inline short static strings
2fd3ed0 
This way short static strings have better cache locality, too.
@ParkMyCar
Copy link
Owner

Fantastic! Thanks @Kijewski!

@ParkMyCar ParkMyCar merged commit f1e0649 into ParkMyCar:main Oct 27, 2023
@Kijewski Kijewski deleted the pr-inline-static branch October 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kijewski @NobodyXu @ParkMyCar