Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis 이슈 수정 #66

Merged

Conversation

JSpiner
Copy link
Contributor

@JSpiner JSpiner commented Oct 31, 2017

1. travis 스크립트 수정

  • app, tedpermission, tedpermission-rx1, tedpermission-rx2 총 4개의 프로젝트가 있는데
    빌드툴과 sdk버전이 23, 25가 섞여있습니다. 그래서 travis 스크립트에 25버전과 23버전 둘다 다운받도록 수정했습니다. 추후엔 같은 버전을 사용하도록 통합하면 좋을것 같아요.

2. lint 옵션 해제

  • 프로젝트에 lint 옵션에 걸리는 코드들이 몇개 있어서, 로컬에서도 build fail이 발생하고있습니다. (아래 스크린샷 참고)여러부분에서 발생하고 있어서, 일단 lint 옵션을 해제했습니다.

2017-10-31 2 55 11

@JSpiner
Copy link
Contributor Author

JSpiner commented Oct 31, 2017

@ParkSangGwon 리뷰 부탁드립니다.

@ParkSangGwon ParkSangGwon merged commit 7cdcaec into ParkSangGwon:master Nov 7, 2017
@ParkSangGwon
Copy link
Owner

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants