Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBID-11: Integrate new compound cookie #9

Merged
merged 12 commits into from
May 12, 2020

Conversation

icflournoy
Copy link

@icflournoy icflournoy commented May 6, 2020

  • read new _parrable_id cookie, migrating values from the old _parrable_eid and _parrable_optout cookies in the process
  • remove external storage configuration since the cookie name is not / should not be configurable
  • remove old SUBMODULES_THAT_ALWAYS_REFRESH_ID functionality as it's not needed if our submodule does not accept an external storage configuration
  • extend spec tests to cover migration of legacy cookies, better describing the parrable submodule interface

Related documentation PR: Parrable/prebid.github.io#2

START:
ℹ 「wdm」: Compiling...
ℹ 「wdm」:
ℹ 「wdm」: Compiled successfully.
07 05 2020 14:55:55.452:INFO [karma-server]: Karma v4.4.1 server started at http://0.0.0.0:9876/
07 05 2020 14:55:55.452:INFO [launcher]: Launching browsers ChromeHeadless with concurrency 5
07 05 2020 14:55:55.483:INFO [launcher]: Starting browser ChromeHeadless
07 05 2020 14:55:55.901:INFO [HeadlessChrome 81.0.4044 (Linux 0.0.0)]: Connected on socket VRODnADNhR3ozhDeAAAA with id 91685069

Finished in 5.143 secs / 3.042 secs @ 14:56:02 GMT-0400 (EDT)

SUMMARY:
✔ 5503 tests completed
ℹ 3 tests skipped

Migrating from legacy _parrable_eid cookie. The new cookie contains ibaOptout and ccpaOptout status fields
@icflournoy icflournoy changed the title PBID-11: Support Compound Cookie PBID-11: Integrate new compound cookie May 6, 2020
@icflournoy icflournoy changed the base branch from master to parrableIdSystem/base May 7, 2020 18:50
@icflournoy icflournoy marked this pull request as ready for review May 7, 2020 18:52
@icflournoy icflournoy requested a review from ralejandre May 7, 2020 18:52
@icflournoy icflournoy self-assigned this May 7, 2020
@icflournoy
Copy link
Author

@ralejandre let's schedule some time tomorrow to review this on a screenshare.

@icflournoy icflournoy merged commit 5d972c0 into parrableIdSystem/base May 12, 2020
@icflournoy icflournoy deleted the parrableIdSystem/PBID-11 branch May 12, 2020 19:56
icflournoy pushed a commit that referenced this pull request Jul 14, 2020
* Add native support

* Add response testing

* DRY test

* Change required from bool to int

* Set mediaType

* Fixes objects

* Fixes object access

* Remove ad property, only set it for banner

* Update tests

* Moving hardcoding values to constants

* Update docs with native information

* Revert "Add native support"

* Getting rid of CCPA adapter validation (#9)

* fix linter errors (#10)

Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
Co-authored-by: Abimael Martinez <abijr@users.noreply.github.com>
icflournoy pushed a commit that referenced this pull request Dec 18, 2020
* updates for first cut at bidder

* fix up height and width

* adds test spec

* remove hello_world from commit'

* updates to support native and fix issues found in initial review

* fix handling of new node in response for native vs banner

* updates to handle OpenRTB base

* updates to support RTB style calls

* updates to get back to parity

* updates to testing

* updates to test media type handling

* updates to handling testing

* updates to testing

* remove report file

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to handling of gdpr

* Delete hello_world.html

* remove hellow-world-sample

* Pubwise 481 (#7)

* updates to support PubWise bid adapter, test cases and documentation

* updates to fix param tes

* Pubwise 481 (#8)

* fixes for unit testing

* remove unused variables and params

* Updates to Remove Unused Vars (#9)

* remove unused vars

* updates to fix up used and unsused params

* updates to fix up used and unsused params (#10)

* updates to fix up used and unsused params

* updates to remove usersync and add gvlid

* Pubwise 481 (#11)

* updates to remove usersync, add https, and add gvlid

* Update pubwiseBidAdapter.js

* updates to remove json, to remove options hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants