Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthData logic refactor #952

Merged
merged 5 commits into from
Mar 11, 2016
Merged

AuthData logic refactor #952

merged 5 commits into from
Mar 11, 2016

Conversation

flovilmart
Copy link
Contributor

  • refactors OAuth to include anonymous as it's the same logic.
  • Refactors the call logic to make sure all paths are consistent and no early return is send
  • Refactors oauth/index.js into authDataManager/index.js to abstract validation loading + custom modules loading
  • Adds support when the authData hash has more than one provider embedded (and according tests), when multiple linking occur one after the other
  • Moves _auth_data_provider transformation to transform.js on update/create operations to declutter RestWrite
  • Ensures authData is properly set and unchanged on beforeSave/afterSave _User

fixes #880
fixes #934
fixes #755

@flovilmart flovilmart changed the title Anonymous is an OAuth OAuth logic refactor: make sure all success path have the same effects Mar 10, 2016
@flovilmart flovilmart mentioned this pull request Mar 10, 2016
Closed
@codecov-io
Copy link

Current coverage is 91.61%

Merging #952 into master will increase coverage by +0.16% as of 74c0c22

@@            master    #952   diff @@
======================================
  Files           73      73       
  Stmts         4398    4423    +25
  Branches       880     887     +7
  Methods          0       0       
======================================
+ Hit           4022    4052    +30
  Partial         10      10       
+ Missed         366     361     -5

Review entire Coverage Diff as of 74c0c22

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@DrBeak1 DrBeak1 mentioned this pull request Mar 10, 2016
Closed
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart mentioned this pull request Mar 11, 2016
Closed
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart referenced this pull request Mar 11, 2016
@Scoup
Test to show that you can't login with a old facebook user when anony…
0f3116e 
…mous
@flovilmart flovilmart mentioned this pull request Mar 11, 2016
Closed
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart changed the title OAuth logic refactor: make sure all success path have the same effects AuthData logic refactor Mar 11, 2016
flovilmart added a commit that referenced this pull request Mar 11, 2016
@flovilmart
Merge pull request #952 from ParsePlatform/flovilmart.OAuthImprovements
7d78732 
AuthData logic refactor
@flovilmart flovilmart merged commit 7d78732 into master Mar 11, 2016
@flovilmart flovilmart deleted the flovilmart.OAuthImprovements branch March 11, 2016 20:38
@luizfelipetx luizfelipetx mentioned this pull request Mar 16, 2016
Closed
@ashish-naik ashish-naik mentioned this pull request Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@flovilmart @codecov-io @facebook-github-bot @gfosco @nlutsenko