Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthData logic refactor #952

Merged
merged 5 commits into from
Mar 11, 2016
Merged

AuthData logic refactor #952

merged 5 commits into from
Mar 11, 2016

Conversation

flovilmart
Copy link
Contributor

  • refactors OAuth to include anonymous as it's the same logic.
  • Refactors the call logic to make sure all paths are consistent and no early return is send
  • Refactors oauth/index.js into authDataManager/index.js to abstract validation loading + custom modules loading
  • Adds support when the authData hash has more than one provider embedded (and according tests), when multiple linking occur one after the other
  • Moves _auth_data_provider transformation to transform.js on update/create operations to declutter RestWrite
  • Ensures authData is properly set and unchanged on beforeSave/afterSave _User

fixes #880
fixes #934
fixes #755

@flovilmart flovilmart changed the title Anonymous is an OAuth OAuth logic refactor: make sure all success path have the same effects Mar 10, 2016
@codecov-io
Copy link

Current coverage is 91.61%

Merging #952 into master will increase coverage by +0.16% as of 74c0c22

@@            master    #952   diff @@
======================================
  Files           73      73       
  Stmts         4398    4423    +25
  Branches       880     887     +7
  Methods          0       0       
======================================
+ Hit           4022    4052    +30
  Partial         10      10       
+ Missed         366     361     -5

Review entire Coverage Diff as of 74c0c22

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.OAuthImprovements branch from b992cd3 to b09a388 Compare March 11, 2016 05:10
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.OAuthImprovements branch from b09a388 to bcffcba Compare March 11, 2016 14:02
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.OAuthImprovements branch from 18ea2bd to 13664a9 Compare March 11, 2016 20:00
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.OAuthImprovements branch from 13664a9 to f41e3c5 Compare March 11, 2016 20:11
@flovilmart flovilmart force-pushed the flovilmart.OAuthImprovements branch from f41e3c5 to daad05a Compare March 11, 2016 20:14
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart changed the title OAuth logic refactor: make sure all success path have the same effects AuthData logic refactor Mar 11, 2016
flovilmart added a commit that referenced this pull request Mar 11, 2016
@flovilmart flovilmart merged commit 7d78732 into master Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants