Move ParselyAPIConnection to Kotlin
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 51.63% 51.22% -0.41%
==========================================
Files 10 10
Lines 368 367 -1
Branches 55 56 +1
==========================================
- Hits 190 188 -2
Misses 165 165
- Partials 13 14 +1
☔ View full report in Codecov by Sentry. |
wzieba
force-pushed
the
parsely_api_connection_to_kotlin
branch
from
df47843 to
cc43b9f
Compare
We don't need such check in this SDK. Also, it can be false positive when moving from Java to Kotlin
wzieba
force-pushed
the
parsely_api_connection_to_kotlin
branch
from
cc43b9f to
5769882
Compare
ParaskP7
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
👋 @wzieba !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟
I have left a questions (❓) and some minor (🔍) comments for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.
parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.kt
Show resolved
Hide resolved
parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.kt
Show resolved
Hide resolved
parsely/src/main/java/com/parsely/parselyandroid/ParselyAPIConnection.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR moves
ParselyAPIConnectionto Kotlin. I need it to be in Kotlin to introduce migrate fromAsyncTaskused in this class to Kotlin Coroutines. So please note, that this class will be heavily rewritten in next PRs.How to test
As this change changes code in HTTP communication, which is mocked in our tests, please:
MainActivity.java#31and make the sample app not in the debug mode