PCH Editor Sidebar: Rename Related Top Posts #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acicovic
commented
Feb 26, 2024
vaurdan
approved these changes
Feb 26, 2024
acicovic
deleted the
update/replace-top-with-related-posts-in-pch-editor-sidebar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactoring that renames
Related Top PoststoRelated Postsboth in code (e.g. file names, CSS selectors, etc.) and displayed text. It also fixes a couple of failing E2E tests.Motivation and context
How has this been tested?
Basic manual testing. A couple of E2E tests have been updated, although we still have one failing test that seems to actually be related to a bug, and should be looked into separately.