-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCH Performance Stats: Add Multi-percentage bar hover state #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarCloud duplication warning can be safely ignored. |
acicovic
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left a comment.
src/content-helper/editor-sidebar/performance-details/component-panel-categories.tsx
Outdated
Show resolved
Hide resolved
…Parsely/wp-parsely into add/hover-effect-performance-categories
Pushed a commit to bring the Multi-percentage bar animation closer to what we have in the design: Notes:
|
acicovic
changed the title
PCH Performance Stats: Add a tooltip with additional information to the category percentage bar
PCH Performance Stats: Add Multi-percentage bar hover state
Mar 4, 2024
acicovic
approved these changes
Mar 4, 2024
Amazing, thanks for working on those improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a nice tooltip and some CSS animation when hovering a section of the multi percentage bar on the Category panel.
Motivation and context
How has this been tested?
Tested locally with all the new changes validated.