-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removeEditorPanel() deprecation message in WordPress 6.5 #2398
Fix removeEditorPanel() deprecation message in WordPress 6.5 #2398
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThe update modifies the excerpt panel removal process in a WordPress editor by incorporating a conditional check. This enhancement ensures compatibility with the deprecation changes introduced in WordPress 6.5, improving the reliability and future-proofing of the feature. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Added a question, but still approved!
Description
In the PCH Excerpt Generator, we were using
dispatch( 'core/edit-post' ).removeEditorPanel( 'post-excerpt' )
which is now deprecated in favor ofdispatch( 'core/editor' ).removeEditorPanel( 'post-excerpt' )
on WordPress 6.5 and newer.This PR allows WordPress 6.5 to use the new code, and keeps the legacy code for older WordPress versions. Unfortunately, a couple of
// ts-ignore
comments needed to be added to stop TypeScript from complaining and failing builds.Motivation and context
Resolve deprecation messages while keeping backward compatibility.
How has this been tested?
Summary by CodeRabbit