-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCH Editor Sidebar: Update isDismissible in Notices #2428
PCH Editor Sidebar: Update isDismissible in Notices #2428
Conversation
WalkthroughThe changes across various components indicate a trend of removing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added a couple comments, let me know if they make sense!
Description
In this PR, we are removing unneeded
isDismissible: true
code from ourNotice
s (this property is set totrue
by default). We're also making a couple of notices dismissable, to be aligned with what we've already done in Smart Linking.Motivation and context
UX coherence, remove unneeded code.
How has this been tested?
Manually tested that code behaves as expected.
Summary by CodeRabbit
isDismissible
property from notification components across various modules, streamlining user notifications and alerts.