Update version number and changelog for 3.16.1 release #2659
Conversation
WalkthroughWalkthroughThe Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (5)
build/content-helper/editor-sidebar-rtl.cssis excluded by!build/**build/content-helper/editor-sidebar.asset.phpis excluded by!build/**build/content-helper/editor-sidebar.cssis excluded by!build/**build/content-helper/editor-sidebar.jsis excluded by!build/**package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (13)
- CHANGELOG.md (1 hunks)
- README.md (1 hunks)
- package.json (1 hunks)
- src/Models/class-smart-link.php (1 hunks)
- src/class-dashboard-link.php (2 hunks)
- src/class-permissions.php (1 hunks)
- src/content-helper/editor-sidebar/class-editor-sidebar.php (3 hunks)
- src/content-helper/editor-sidebar/smart-linking/component.tsx (1 hunks)
- src/content-helper/editor-sidebar/smart-linking/review-modal/component-block-preview.tsx (3 hunks)
- src/content-helper/editor-sidebar/smart-linking/smart-linking.scss (2 hunks)
- tests/e2e/specs/content-helper/top-bar-icon.spec.ts (3 hunks)
- tests/e2e/utils.ts (2 hunks)
- wp-parsely.php (2 hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
Additional context used
Path-based instructions (10)
src/class-dashboard-link.php (1)
Pattern
**/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
- Ensure the code follows WordPress coding standards and is well-documented.
- Confirm the code is secure and free from vulnerabilities.
- Optimize the code for performance, removing any unnecessary elements.
- Validate comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."
tests/e2e/specs/content-helper/top-bar-icon.spec.ts (1)
Pattern
**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the code to ensure it is well-structured and adheres to best practices.
- Verify compliance with WordPress coding standards.
- Ensure the code is well-documented.
- Check for security vulnerabilities and confirm the code is secure.
- Optimize the code for performance, removing any unnecessary elements.
- Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
- Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/content-helper/editor-sidebar/class-editor-sidebar.php (1)
Pattern
**/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
- Ensure the code follows WordPress coding standards and is well-documented.
- Confirm the code is secure and free from vulnerabilities.
- Optimize the code for performance, removing any unnecessary elements.
- Validate comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/class-permissions.php (1)
Pattern
**/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
- Ensure the code follows WordPress coding standards and is well-documented.
- Confirm the code is secure and free from vulnerabilities.
- Optimize the code for performance, removing any unnecessary elements.
- Validate comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/content-helper/editor-sidebar/smart-linking/review-modal/component-block-preview.tsx (1)
Pattern
**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the code to ensure it is well-structured and adheres to best practices.
- Verify compliance with WordPress coding standards.
- Ensure the code is well-documented.
- Check for security vulnerabilities and confirm the code is secure.
- Optimize the code for performance, removing any unnecessary elements.
- Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
- Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
tests/e2e/utils.ts (1)
Pattern
**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the code to ensure it is well-structured and adheres to best practices.
- Verify compliance with WordPress coding standards.
- Ensure the code is well-documented.
- Check for security vulnerabilities and confirm the code is secure.
- Optimize the code for performance, removing any unnecessary elements.
- Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
- Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/content-helper/editor-sidebar/smart-linking/smart-linking.scss (1)
Pattern
**/*.{css,scss}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the SCSS code to ensure it is well-structured and adheres to best practices.
- Convert dimensions greater than or equal to 3px to rem units using the to_rem function.
- Utilize variables for sizes and colors defined in src/content-helper/common/css/variables.scss instead of hardcoding values."
wp-parsely.php (1)
Pattern
**/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
- Ensure the code follows WordPress coding standards and is well-documented.
- Confirm the code is secure and free from vulnerabilities.
- Optimize the code for performance, removing any unnecessary elements.
- Validate comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/Models/class-smart-link.php (1)
Pattern
**/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
- Ensure the code follows WordPress coding standards and is well-documented.
- Confirm the code is secure and free from vulnerabilities.
- Optimize the code for performance, removing any unnecessary elements.
- Validate comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."
src/content-helper/editor-sidebar/smart-linking/component.tsx (1)
Pattern
**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the code to ensure it is well-structured and adheres to best practices.
- Verify compliance with WordPress coding standards.
- Ensure the code is well-documented.
- Check for security vulnerabilities and confirm the code is secure.
- Optimize the code for performance, removing any unnecessary elements.
- Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
- Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
Additional comments not posted (35)
src/class-dashboard-link.php (2)
28-28: Update the docblock to reflect the changes.The docblock has been updated to indicate that the
$campaignand$sourceparameters are now optional.
Line range hint
36-64:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
generate_urlmatch the new signature.Verification successful
Verification Successful: All function calls to
generate_urlmatch the new signature.The function
generate_urlhas been correctly updated in all instances across the codebase to match the new signature.
src/content-helper/editor-sidebar/class-editor-sidebar.phpat lines 123 and 126tests/Integration/DashboardLinkTest.phpat lines 48 and 69src/UI/class-row-actions.phpat line 78src/UI/class-admin-bar.phpat line 89Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `generate_url` match the new signature. # Test: Search for the function usage. Expect: Only occurances of the new signature. rg --type php -A 5 $'generate_url'Length of output: 4739
Script:
#!/bin/bash # Description: Verify all function calls to `generate_url` match the new signature. # Extract lines where generate_url is called in the identified files. rg --type php 'generate_url' -n -A 0 -B 0Length of output: 1470
package.json (1)
3-3: Version number update approved.The version number has been correctly updated to "3.16.1".
tests/e2e/specs/content-helper/top-bar-icon.spec.ts (2)
Line range hint
4-14:
Import statement changes approved.The
toggleMoreMenufunction has been correctly moved from a grouped import to an individual import.
85-85: Function call update approved.The parameter
'open'has been correctly added to thetoggleMoreMenufunction call.src/content-helper/editor-sidebar/class-editor-sidebar.php (3)
98-98: Update the docblock to reflect the changes.The docblock has been updated to indicate that the
$add_utm_paramsparameter has been added.
168-169: Function call update approved.The parameter
falsehas been correctly passed to theget_parsely_post_urlfunction call to ensure that UTM parameters are not added to the URL.
Line range hint
101-125:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
get_parsely_post_urlmatch the new signature.Verification successful
Verification successful: All function calls to
get_parsely_post_urlmatch the new signature.
- The function call
$this->get_parsely_post_url( null, false );matches the updated signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `get_parsely_post_url` match the new signature. # Test: Search for the function usage. Expect: Only occurances of the new signature. rg --type php -A 5 $'get_parsely_post_url'Length of output: 1214
src/class-permissions.php (6)
84-85: Ensure variable initialization.The
$user_rolesvariable is initialized correctly by fetching the roles of the current user.
86-87: Handle edge case: User with no roles.The function correctly handles the case where the user has no roles.
91-93: Retrieve valid roles with edit_posts capability.The function retrieves roles with the capability to edit posts using
array_keys.
94-95: Check user roles against valid roles.The function checks if at least one of the user's roles has the capability to edit posts using
array_intersect.
99-103: Check user roles against allowed roles.The function checks if at least one of the user's roles has access to the specific feature/post using
array_intersect.
105-107: Check if user can edit the post.The function checks if the user can edit the post when a valid post ID is provided.
src/content-helper/editor-sidebar/smart-linking/review-modal/component-block-preview.tsx (9)
9-9: ImportuseStatefrom@wordpress/element.The
useStatehook is correctly imported and necessary for managing state in the component.
17-26: DefineStyletype.The
Styletype is defined correctly and includes optional properties.
32-35: Updatestylesprop inStylesPropsto useStyletype.The
stylesprop is correctly updated to use the newStyletype.
48-95: AddprefixSelectorsfunction.The
prefixSelectorsfunction is correctly implemented to prefix CSS selectors.
97-97: AddprocessedStylesstate.The
processedStylesstate is correctly initialized usinguseState.
99-121: AddprocessStylesfunction.The
processStylesfunction is correctly implemented to process styles with prefixing.
104-121: ModifyuseEffectto process styles with prefixing.The
useEffecthook is correctly modified to process styles with prefixing.
125-126: Update JSX to useprocessedStyles.The JSX elements are correctly updated to use
processedStylesinstead offilteredStyles.
261-276: Modify JSX structure inBlockPreview.The structure of JSX elements in
BlockPreviewis correctly updated.README.md (3)
3-3: Update version information.The version information is correctly updated from 3.16.0 to 3.16.1.
3-3: Specify PHP requirement.The PHP requirement is correctly specified as 7.2.
3-3: Update tested version.The tested version is correctly updated to 6.5.
tests/e2e/utils.ts (2)
11-11: UpdatePLUGIN_VERSIONconstant.The
PLUGIN_VERSIONconstant is correctly updated from '3.16.0' to '3.16.1'.
246-281: AddtoggleMoreMenufunction.The
toggleMoreMenufunction is correctly implemented to replace thefindSidebarPanelToggleButtonWithTitlefunction.src/content-helper/editor-sidebar/smart-linking/smart-linking.scss (2)
507-507: Use variables for colors.Ensure that the color is using variables defined in
variables.scssinstead of hardcoding values.- color: var(--sidebar-black) !important; + color: var(--sidebar-black) !important;Likely invalid or redundant comment.
492-495: Use rem units for dimensions.Ensure that dimensions greater than or equal to 3px are converted to rem units using the
to_remfunction.- padding-bottom: 0; - font-size: var(--font-size--medium); + padding-bottom: to_rem(0); + font-size: to_rem(var(--font-size--medium));Likely invalid or redundant comment.
wp-parsely.php (2)
14-14: Version update confirmed.The plugin version has been correctly updated to 3.16.1.
73-73: Constant update confirmed.The
PARSELY_VERSIONconstant has been correctly updated to 3.16.1.src/Models/class-smart-link.php (2)
132-137: Conditional title assignment confirmed.The logic for setting the
titleproperty based ondestination_post_idis correct and efficient.
131-131: Property assignment confirmed.The
titleproperty assignment in the constructor is consistent with the updated logic.src/content-helper/editor-sidebar/smart-linking/component.tsx (1)
485-495: State setting logic confirmed.The logic for setting
IsReviewModalOpenbased onsmartLinks.length === 0is correct and enhances error handling.
Comments failed to post (1)
src/content-helper/editor-sidebar/smart-linking/smart-linking.scss
495-495: Use variables for background colors.
Ensure that the background color is using variables defined in
variables.scssinstead of hardcoding values.- background: var(--Gutenberg-White, #fff); + background: var(--Gutenberg-White);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.background: var(--Gutenberg-White);
This PR updates the plugin's version number and changelog in preparation for the 3.16.1 release.
Fixed
Summary by CodeRabbit
New Features
get_parsely_post_url).Bug Fixes
Documentation
Chores