Move Settings page to src/UI/

[acicovic]

Description

This PR removes the /views/ directory and moves the Settings page to /src/UI/.

Motivation and context

Closes #1941.

How has this been tested?

• Manually tested that the Settings page still works.
• Automated testing passes.

Summary by CodeRabbit

• New Features
  • Updated settings page rendering for improved structure.
• Bug Fixes
  • Adjusted paths for PHPStan analysis to enhance type checking.
• Chores
  • Removed the views/ directory from various configurations to streamline package distribution.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on the removal of the views/ directory from various configurations and updates to file paths. The package.json file has been adjusted to exclude the views/ directory from the package distribution and includes comments on dependency management. The phpstan.neon file has been updated for stricter type checking and also excludes the views/ directory from analysis. Additionally, the Settings_Page class and its corresponding test class have updated their file inclusions to reflect the new structure.

Changes

File(s)	Change Summary
package.json	Removed "views/" from the "files" array; updated devDependenciesComments and overridesComments.
phpstan.neon	Updated ignoreErrors to include missingType.generics; removed views/ from paths.
rector.php	Removed __DIR__ . '/views' from directories to process.
src/UI/class-settings-page.php, tests/Integration/UI/SettingsPageTest.php	Updated file inclusions from views/parsely-settings.php to src/UI/settings-page.php.

Assessment against linked issues

Objective	Addressed	Explanation
Consider moving/removing views directory (#1941)	✅

Possibly related PRs

• Update WordPress typing packages #2841: This PR updates the package.json file, which is also modified in the main PR, indicating a direct connection in terms of dependency management.
• Remove repeated-metas.php and move class-meta-renderer.php #2849: This PR involves the removal of a view file (views/repeated-metas.php), which aligns with the main PR's removal of the "views/" directory from various configurations, suggesting a related restructuring of the codebase.

Suggested labels

Type: Refactoring

Suggested reviewers

• vaurdan

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 03ad5a6 and c761db0.

📒 Files selected for processing (5)

• package.json (0 hunks)
• phpstan.neon (0 hunks)
• rector.php (0 hunks)
• src/UI/class-settings-page.php (1 hunks)
• tests/Integration/UI/SettingsPageTest.php (1 hunks)

💤 Files with no reviewable changes (3)

• package.json
• phpstan.neon
• rector.php

✅ Files skipped from review due to trivial changes (1)

• tests/Integration/UI/SettingsPageTest.php

🧰 Additional context used

📓 Path-based instructions (1)

src/UI/class-settings-page.php (1)

Pattern **/*.{html,php}: "Perform a detailed review of the provided code with following key aspects in mind:

• Review the HTML and PHP code to ensure it is well-structured and adheres to best practices.
• Ensure the code follows WordPress coding standards and is well-documented.
• Confirm the code is secure and free from vulnerabilities.
• Optimize the code for performance, removing any unnecessary elements.
• Validate comments for accuracy, currency, and adherence to WordPress coding standards.
• Ensure each line comment concludes with a period.
• Verify code compatibility with the latest version of WordPress, avoiding deprecated functions or features."

🔇 Additional comments (1)

src/UI/class-settings-page.php (1)

237-237: Approved: File inclusion updated to reflect new directory structure.

This change aligns perfectly with the PR objective of moving the Settings page to the /src/UI/ directory and removing the /views/ directory. It contributes to streamlining the project structure as intended.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.