Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate kwargs in bash_app call rather than modifying reusable dict #1413

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

benclifford
Copy link
Collaborator

The xfailing test for this needed updating a bit to reflect
recent changes in parsl.

Fixes issue #1058

The xfailing test for this needed updating a bit to reflect
recent changes in parsl.

Fixes issue #1058
Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still wouldn't save us if the kwargs include say another dict, or list.
I'm not sure if it's worth making a deep copy every time either.

@benclifford
Copy link
Collaborator Author

What goes wrong in the case that the default value is a dict? It can be modified by an app running in a local thread executor and I think that modification is seen by all invocations, which is correct python semantics. In the case of a different-process executor like HTEX those modifications don't change the submit side values, which is parsl's behaviour for any objects passed in as a parameter.

@yadudoc
Copy link
Member

yadudoc commented Oct 29, 2019

I tested this out a bit, and i don't think the situation where one of the args is a dict itself, is a concern for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants