Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and check types on monitoring router and database processes #3572

Merged
merged 5 commits into from
Aug 14, 2024

Commits on Aug 8, 2024

  1. mypy does not typecheck this call, so do it with typeguard at runtime...

    (and of course it fails...)
    benclifford committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9e2935c View commit details
    Browse the repository at this point in the history
  2. router type annotations were incorrectly introduced in PR #1936 in 2021

    they were introduced as `queue` module queues, but actually the values
    (and the annotations used at the other end of the router_starter call)
    are multiprocessing.Queue (subclasses...)
    
    mypy does not typecheck this call... a later PR introduces typeguard here
    (which detects this)
    
    this hasn't caused execution problems - the APIs of the two queue types are close enough
    - but it is incorrect when trying to understand how pieces of monitoring
    communicate with each other.
    benclifford committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    467f006 View commit details
    Browse the repository at this point in the history
  3. Use explicit prefix for queue type for clarity, specifically because …

    …there are multiple Queue types floating around with very similar interfaces
    benclifford committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d3dd11e View commit details
    Browse the repository at this point in the history
  4. remove generics on multiprocessing Queue objects; convert # type: ann…

    …otations in modern type syntax
    benclifford committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    58e591d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    e34b042 View commit details
    Browse the repository at this point in the history