Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more usage tracking to htex_local_alternate test #3625

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

benclifford
Copy link
Collaborator

This uses the project name feature introduced in PR #3624 in one of the standard Parsl tests that already had usage turned on.

Changed Behaviour

More usage tracking on pytest parsl/tests/ --config parsl/tests/configs/htex_local_alternate.py which runs in CI and often on my laptop.

Type of change

  • New feature

Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming ... this (and the previous True) doesn't "phone home," right?

@benclifford
Copy link
Collaborator Author

this (and the previous True) doesn't "phone home," right?

both do.

@danielskatz
Copy link
Member

this (and the previous True) doesn't "phone home," right?

both do.

Maybe more accurately would be that they send postcards (UDP packets)

@benclifford
Copy link
Collaborator Author

I had an out-of-band conversation with @khk-globus about this. His concern was that the statistics would be in some sense corrupted by the presence of automated Parsl executions. This has been raised by a few people.

My attitude is that we should be encouraging every instantiation of a DFK to be reported. We should not be pushing "do we want this in our stats?" decisions onto our end users. @NishchayKarle implemented #3624 to add a user specifiable usage tracking project name. Users can describe their usage of Parsl here, if they want to, and that can help the end users of statistics make decisions about what to do with various counts - especially, if they are concerned that their automated testing will skew some perceived use of the stats, they can disclose that in the project name (for example, project_name="Ben's automated tests")

@benclifford benclifford merged commit aab398a into master Oct 3, 2024
8 checks passed
@benclifford benclifford deleted the benc-usage-more branch October 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants