Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive tweaks #755

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Responsive tweaks #755

merged 2 commits into from
Nov 3, 2024

Conversation

dotsam
Copy link
Contributor

@dotsam dotsam commented Nov 1, 2024

Some tweaks to better support mobile widths. The diff here doesn't look great owing to some larger markup/nesting changes, but here's what's happening:

  • Tweak the data tables layout, as it appears it was using some Bootstrap 4 markup that's no longer valid
  • Tweak the single part info, mainly making the image full-width and smaller screen sizes so that the image slider is usable and therefore the other two columns have more width to display in
  • Added some more checks around part properties so no empty markup is output
  • Converted the displayed part properties into a <dl> Description List and removed the use of <h6>, as this is a better semantic fit. Also provided more accessible markup while retaining the tooltips

If this final change to <dl>'s looks okay to you, I'm also working on doing the same thing to the single part "sidebar" and can submit a PR for that too

@jbtronics jbtronics merged commit 65b2f04 into Part-DB:master Nov 3, 2024
@jbtronics
Copy link
Member

looks good, thank you.
I will just adjust the font-weight of the

elements to match the
style, as they should appear slightly highlighted over normal text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants