Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wayland:client for wayland bindings. #10

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

rtbo
Copy link
Contributor

@rtbo rtbo commented Jan 18, 2018

wayland-client-d is not maintained anymore.
wayland:client replaces it.

wayland-client-d is not maintained anymore.
[wayland:client](https://github.com/rtbo/wayland-d) replaces it.
@ParticlePeter
Copy link
Owner

ParticlePeter commented Feb 1, 2018

I am really sorry for the delayed reply. Thanks for Information and pull request. I have no linux test system so I need to trust you on this, but I noticed one thing:
VkWaylandSurfaceCreateInfoKHR has a field of type wl_display* but you have removed the definition of that type, how can this work?


enum VK_KHR_WAYLAND_SURFACE_SPEC_VERSION = 6;
enum VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME = "VK_KHR_wayland_surface";

alias VkWaylandSurfaceCreateFlagsKHR = VkFlags;
struct wl_display;
struct wl_surface;
alias wl_surface = wl_proxy;
Copy link
Owner

@ParticlePeter ParticlePeter Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VkWaylandSurfaceCreateInfoKHR has a field of type wl_display* but you have removed the definition of that type, how can this work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wl_display is imported by wayland.native.client.
Having a local definition makes erupted expecting erupted.types.wl_display, whereas application code is supplying wayland.native.client.wl_display

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I have no opportunity to test this, but I assume that it works at your side, hence I will trust you.
Btw, I don't like the fact that erupted has so many dependencies even if not used. I am working on (or rather postponing ...) a version which does have no dependencies at all, and all the platform specific code is implemented as several template mixins. So its in the users hand to decide which libraries he wants to use. What do you think about this approach?

@ParticlePeter
Copy link
Owner

Btw, how impolite of me! Thanks for the note and contribution!

@ParticlePeter ParticlePeter merged commit dcc5771 into ParticlePeter:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants