Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise some exception messages #447

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Revise some exception messages #447

merged 1 commit into from
Oct 12, 2017

Conversation

bording
Copy link
Member

@bording bording commented Oct 11, 2017 •
edited by adamralph
Loading

Connects to #427.

@bording bording requested a review from a team October 11, 2017 22:37
@bording bording added this to the 5.0.0 milestone Oct 11, 2017
@bording bording mentioned this pull request Oct 11, 2017
Closed
@adamralph adamralph merged commit 174c152 into develop Oct 12, 2017
@adamralph adamralph deleted the tweak-exception-messages branch October 12, 2017 06:55
@adamralph adamralph removed this from the 5.0.0 milestone Oct 12, 2017
@adamralph
Copy link
Contributor

adamralph commented Oct 12, 2017 •
edited
Loading

FYI I connected this with #427 and removed it from the milestone, since it is fixing the exception message which was introduced in the implementation of that issue.

That means that the addition of the full stops to the other two exception messages will not appear in our release notes, but I think we can live with that. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamralph adamralph adamralph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bording @adamralph