Use official extension point to add PDBs #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bording awesome. i will apply that to my other projects |
SimonCropp
reviewed
Jul 18, 2017
| </PropertyGroup> | ||
|
|
||
| <!-- Target is needed until we can enable GeneratePackageOnBuild again --> | ||
| <Target Name="IncludePDBsInPackage" BeforeTargets="_GetPackageFiles" Condition="'$(IncludeBuildOutput)' != 'false'"> | ||
| <Target Name="IncludePDBsInPackage" Condition="'$(IncludeBuildOutput)' != 'false'"> |
There was a problem hiding this comment.
why is IncludeBuildOutput required? dont we always want pdbs included?
There was a problem hiding this comment.
This applies to all projects, including the projects that create source packages: https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.AcceptanceTests/NServiceBus.AcceptanceTests.csproj#L31
Without that, it would put the PDBs in there as well.
There was a problem hiding this comment.
I suppose I could have put the condition on the TargetsForTfmSpecificContentInPackage property instead, but it looked better on the target.
SimonCropp
approved these changes
Jul 18, 2017
dbelcham
approved these changes
Jul 18, 2017
timbussmann
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the official TFM-specific content extension point introduced in NuGet/NuGet.Client#1255 to add the PDBs to the packages.
CC: @SimonCropp