Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using FastExpressionCompiler to compile the pipeline expression tree #5071

Merged
merged 2 commits into from
Aug 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,9 @@ SimpleJson sources are compiled into the NServiceBus distribution as allowed und
net-object-deep-copy is licensed under the MIT license as described [here](https://github.com/Burtsev-Alexey/net-object-deep-copy/blob/master/README).

net-object-deep-copy sources are compiled into the NServiceBus distribution as allowed under the license terms found [here](https://github.com/Burtsev-Alexey/net-object-deep-copy/blob/master/README).

### [FastExpressionCompiler](https://github.com/dadhi/FastExpressionCompiler)

FastExpressionCompiler is licensed under the MIT license as described [here](https://github.com/dadhi/FastExpressionCompiler/blob/master/LICENSE).

FastExpressionCompiler sources are compiled into the NServiceBus distribution as allowed under the license terms found [here](https://github.com/dadhi/FastExpressionCompiler/blob/master/LICENSE).
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
context2 => value(NServiceBus.Core.Tests.Pipeline.PipelineTests+Stage1).Invoke(context2, value(System.Func`2[NServiceBus.Pipeline.IIncomingLogicalMessageContext,System.Threading.Tasks.Task])),
context3 => value(NServiceBus.Core.Tests.Pipeline.PipelineTests+Behavior2).Invoke(context3, value(System.Func`2[NServiceBus.Pipeline.IIncomingLogicalMessageContext,System.Threading.Tasks.Task])),
context4 => value(NServiceBus.Core.Tests.Pipeline.PipelineTests+Stage2).Invoke(context4, value(System.Func`2[NServiceBus.Pipeline.IDispatchContext,System.Threading.Tasks.Task])),
context5 => value(NServiceBus.Core.Tests.Pipeline.PipelineTests+Terminator).Invoke(context5, value(System.Func`2[NServiceBus.Pipeline.PipelineTerminator`1+ITerminatingContext[NServiceBus.Pipeline.IDispatchContext],System.Threading.Tasks.Task])),
context5 => value(NServiceBus.Core.Tests.Pipeline.PipelineTests+Terminator).Invoke(context5, value(System.Func`2[NServiceBus.Pipeline.PipelineTerminator`1+ITerminatingContext[NServiceBus.Pipeline.IDispatchContext],System.Threading.Tasks.Task`1[System.Int32]])),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be relevant since Task<TResult> is always assignable to Task.

3 changes: 2 additions & 1 deletion src/NServiceBus.Core.Tests/DocumentationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ void AddIfEmpty(Element element)
{
return;
}
if (currentMember.DeclaringType != null && currentMember.DeclaringType.FullName.Contains("JetBrains"))
var declaringType = currentMember.DeclaringType;
if (declaringType != null && declaringType.FullName.Contains("JetBrains") || declaringType.FullName.Contains("FastExpressionCompiler"))
{
return;
}
Expand Down
1 change: 1 addition & 0 deletions src/NServiceBus.Core.Tests/StandardsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public void NonPublicShouldHaveSimpleNamespace()
!x.FullName.StartsWith("Newtonsoft.Json") &&
!x.FullName.StartsWith("LightInject") &&
!x.FullName.StartsWith("SimpleJson") &&
!x.FullName.StartsWith("FastExpressionCompiler") &&
x.Name != "GitVersionInformation" &&
x.Namespace != "Particular.Licensing" &&
x.Namespace != "NServiceBus.Features" &&
Expand Down
Loading