Endpoints containing sagas fail to start when a scanned assembly contains a ref struct #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
commented
Oct 28, 2024
mikeminutillo
approved these changes
Oct 29, 2024
Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
danielmarbach
approved these changes
Oct 29, 2024
|
@poornimanayar @danielmarbach did some benchmarking and the strin.equals version of .CustomAttributes seems to be most performant but its very close
|
|
The test was iterating all scanned types of an endpoint running the learning transport and persister |
|
Since I ran the tests on .net8 I'll switch to equals since its likely that the performance gains are even larger on .net451 |
poornimanayar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7187 which fixes #7179 for the release-9.1 branch