Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ordering of the events #3937

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix incorrect ordering of the events #3937

merged 1 commit into from
Jan 22, 2024

Conversation

soujay
Copy link
Contributor

@soujay soujay commented Jan 19, 2024

Removes OrderingType.Double, with no value passed RavenDB 5.x defaults to lexicographic ordering:

When using RQL directly, if no ordering type is specified, then the server defaults to lexicographic ordering.

The document property on which is sorted is RaisedAt. This value is stored/interpreted as 2020-05-27T00:00:00.0000000Z. Using lexicographic ordering will work correctly with these values.

Symptoms

Incorrect order of events in ServicePulse events view.

Who's affected

ServiceControl 5 instances

Root cause

Incorrect OrderingType was passed to RavenDB query.

@soujay soujay self-assigned this Jan 19, 2024
@soujay soujay modified the milestone: 5.0.4 Jan 19, 2024
@ramonsmits
Copy link
Member

I see that OrderingType.Double is removed. However, the RavenDB docs state:

When using RQL directly, if no ordering type is specified, then the server defaults to lexicographic ordering.

The document property on which is sorted is RaisedAt. If this is indeed lexicographic then it depends on the culture that RavenDB uses on how these timestamps are sorted.

@soujay soujay merged commit 89c444b into master Jan 22, 2024
11 checks passed
@soujay soujay deleted the events-ordering branch January 22, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect ordering of events in Dashboard and Events page
3 participants