Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI is too chatty with SC #341

Closed
distantcam opened this issue Jun 16, 2014 · 4 comments
Closed

SI is too chatty with SC #341

distantcam opened this issue Jun 16, 2014 · 4 comments
Assignees
Labels

Comments

@distantcam
Copy link
Contributor

ServiceInsight will often send 2 or 3 web requests to SC for every action that it does. This is fine when SC is localhost but not so good when running over the internet.

Instead, SI should cache web requests, which should help with overall performance.

@dannycohen
Copy link

@distantcam - the issue is phrased too generally and it is unclear what needs to be done / fixed.

  • Which actions are chatty ?
  • How chatty are these actions ?
  • What is the chattiness interaction delay over the internet (estimated) ?

@distantcam
Copy link
Contributor Author

@dannycohen I was still investigating, and made this issue as a reminder to come back to this.

I was noticing repeated calls to the same url from SI in the logs. It turns out this is when a different message from the same saga is selected, and SI isn't smart enough to realize it's the same data and avoid the call to SC.

Given saga data can be up to 3mb each, avoiding having to process that much data everytime would be nice.

@dannycohen
Copy link

@distantcam - Makes sense. please ping when you get to analyze this in depth.

when a different message from the same saga is selected, and SI isn't smart enough to realize it's the same data and avoid the call to SC

Note that in such a case, caching only would be bad, since the Saga data may have changed. Checking for changes in the data on the server side would be a good option.

@johnsimons
Copy link
Member

Fixes as part of #455

@johnsimons johnsimons modified the milestone: 1.2.9 Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants