-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI is too chatty with SC #341
Comments
@distantcam - the issue is phrased too generally and it is unclear what needs to be done / fixed.
|
@dannycohen I was still investigating, and made this issue as a reminder to come back to this. I was noticing repeated calls to the same url from SI in the logs. It turns out this is when a different message from the same saga is selected, and SI isn't smart enough to realize it's the same data and avoid the call to SC. Given saga data can be up to 3mb each, avoiding having to process that much data everytime would be nice. |
@distantcam - Makes sense. please ping when you get to analyze this in depth.
Note that in such a case, caching only would be bad, since the Saga data may have changed. Checking for changes in the data on the server side would be a good option. |
Fixes as part of #455 |
ServiceInsight will often send 2 or 3 web requests to SC for every action that it does. This is fine when SC is localhost but not so good when running over the internet.
Instead, SI should cache web requests, which should help with overall performance.
The text was updated successfully, but these errors were encountered: