Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saga view is vague when is not able to display the saga data #611

Open
HEskandari opened this issue Oct 28, 2016 · 3 comments
Open

Saga view is vague when is not able to display the saga data #611

HEskandari opened this issue Oct 28, 2016 · 3 comments

Comments

@HEskandari
Copy link
Contributor

HEskandari commented Oct 28, 2016

There are a few reasons Saga tab would not be able to display the data for the saga. At the moment we only display 'Empty' label and it is not conclusive enough to understand what happened.

image

It could be either of these cases (that I know of):

  • A lookup request to ServiceControl returns 404 (Not Found). This means ServiceControl somehow doesn't have the saga data anymore, potentially because it is expired (see here)
  • A lookup request to ServiceControl return 204 (Non Content) when the body was not stored due to size limitations.
  • Data returned via ServiceControl can not be parsed or displayed or other exceptions.

Ideally, user should be able to distinguish between the two cases. Suggesting to also revise the SC/SI documents to highlight the first case and the root cause.

@johnsimons
Copy link
Member

@HEskandari You can also receive a 204 (No Content), that is when the message exists but we did not store the body because it was over the limit.
See https://github.com/Particular/ServiceControl/blob/0470e5ed3d651dc2fba998b09d56bd47f6bae6d1/src/ServiceControl/Operations/BodyStorage/RavenAttachments/GetBodyById.cs#L38-L51

@distantcam distantcam added this to the 1.5.8 milestone Nov 2, 2016
@distantcam distantcam added Bug and removed Feature labels Nov 2, 2016
@adamralph adamralph modified the milestones: Future, 1.5.8 Nov 3, 2016
@adamralph
Copy link
Member

Since we are reopening closed bugs on the 1.5.8 milestone due to reverting master to 1.5.7 in #617, this issue has been moved from the 1.5.8 milestone to the Future milestone, to make a distinction.

This may be re-added to the 1.5.8 milestone if we decide to fix it before releasing 1.5.8.

@HEskandari HEskandari removed this from the Future milestone Nov 15, 2016
@HEskandari HEskandari removed their assignment May 1, 2018
@kbaley kbaley added Improvement and removed Bug labels Jan 13, 2021
@kbaley
Copy link
Contributor

kbaley commented Jan 13, 2021

Triaged with @boblangley. We've re-labeled as an improvement as the functionality is not broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants