Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to property display styles in Saga View #666

Closed
HEskandari opened this issue Dec 6, 2016 · 4 comments
Closed

Improvements to property display styles in Saga View #666

HEskandari opened this issue Dec 6, 2016 · 4 comments
Assignees
Milestone

Comments

@HEskandari
Copy link
Contributor

HEskandari commented Dec 6, 2016

There are a few issues with the way property key / values are displayed in SagaView so the following improvements should be made:

image

image

  • Contrast for property names and values is to be increased while keeping special characters de-emphasized.
  • Show the active tab in underlined black text to indicate it's active and can't be clicked again.
  • Mouse cursor should change to Hand when hovering over the links.
  • In order to not have View properties: displaying as if it was another property and better align the display of custom tabs with SP, change tabs labels, reduce font size by 2pt and make it all caps.
@HEskandari HEskandari self-assigned this Dec 6, 2016
@HEskandari
Copy link
Contributor Author

This was done as a part of #648 but we're moving the relevant parts here and only keep the bug / issue in 648.

@HEskandari
Copy link
Contributor Author

@sergioc The screenshot above only shows black color for the selected underlined text. What color should be the 'underline' part when you hover over the not-selected text? In other words, should it behave link other links e.g. link to (xxx bytes)?

@adamralph
Copy link
Contributor

@HEskandari I guess the hover style for a link should continue to be a blue underline. A black underline would look very strange.

@sergioc
Copy link

sergioc commented Dec 8, 2016

What color should be the 'underline' part when you hover over the not-selected text?

Same blue as the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants