-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connecting to ServiceControl does not trigger a refresh of the message list when the endpoint explorer does not have focus #736
Comments
How can you not select anything in the endpoint explorer? You have to have a selection and if it is either the root node, which means all the endpoints or a specific one. Could you please elaborate how you ended up with no selection on Endpoint Explorer? |
@HEskandari When you start SI and don't even expand the Endpoint Explorer. The current code is based on the event that is triggered when you click something in EE. |
@SzymonPobiega Just tried this but still can't repro:
Now could it be that the request is cached locally and doesn't actually hit SC? You should still see the log entries on Logs window. |
@HEskandari I verified it and indeed it does work when you can connect to SC. But when you can't (e.g. temporarily disabled |
@HEskandari @adamralph here's the link to the repro recording: https://drive.google.com/open?id=0B_QSSoVzhDxPbzU2b2JITGM5bHM |
@SzymonPobiega Interesting. I see two issues:
Both might be caused by the same thing. It looks like when you actually connect, the Endpoint Explorer doesn't have a selection as everything is tied to what is selected in the endpoint explorer. |
@SzymonPobiega @HEskandari I've updated the title based on today's discussion. Does it look OK? If not, feel free to edit. |
Original description
If I don't select anything in the `Endpoint Explorer` changing the sort order and/or column does not trigger query to SC to fetch the data. The sorting is done on the local data set. Only when I first click something in the `Endpoint Explorer` the sorting starts to work properly.I suspect this is because of this code https://github.com/Particular/ServiceInsight/blob/master/src/ServiceInsight/MessageList/MessageListViewModel.cs#L102
The text was updated successfully, but these errors were encountered: