Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of a message payload's date fields inside ServiceInsight json viewer #1367

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

soujay
Copy link
Contributor

@soujay soujay commented Jun 13, 2023

Description

If a message payload has a date field, then the value of that date field changes based on the user's computer clock when viewed in ServiceInsight Json viewer.

Expected Behavior

Any data inside the message payload should not be altered while parsing .

Observed Behavior

If a message payload has a date field, then the value of that date field changes based on the user's computer clock when viewed in ServiceInsight Json viewer.

Steps to reproduce

  1. Consider a sample app that has a message payload with some datefields - like birthday, expiration date etc
  2. Set the computer clock to say US timezone East coast
  3. Run the sample app.
  4. Go to ServiceInsight and view message details.
  5. Observe the value of the date field.
    image
  6. Now reset computer clock to say US timezone Pacific
  7. Close ServiceInsight
  8. Reopen ServiceInsight and view message details.
  9. Observe that the value of date field has changed and it now corresponds to PST.
    image

This PR applies DateParseHandling.None to fix the datetime mismatch while parsing

@soujay soujay changed the title Apply DateParseHandling.None to fix the datetime mismatch Date fields inside a message payload are incorrectly parsed in ServiceInsight Jun 13, 2023
@soujay soujay requested a review from WilliamBZA June 13, 2023 04:40
@soujay soujay self-assigned this Jun 13, 2023
@soujay soujay added this to the 2.13.0 milestone Jun 15, 2023
@soujay soujay merged commit a411beb into master Jun 15, 2023
@soujay soujay deleted the datetime-mismatch branch June 15, 2023 02:43
@soujay soujay added the Bug label Jun 15, 2023
@soujay soujay changed the title Date fields inside a message payload are incorrectly parsed in ServiceInsight Incorrect parsing of a message payload's date fields inside ServiceInsight json viewer Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants