Supply instance ID to scaled out ServiceControl for retries #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBZA
approved these changes
Jan 27, 2018
WilliamBZA
changed the title
|
@danielmarbach what would be a good title for this in the context of our release notes? Is it effectively enabling SI to work with a new feature in SC vnext? |
|
It essentially completes the PR for #737 Which should be retitled to "Allow ServiceInsight to connect to scaled out instances of ServiceControl" This particular PR is an optimization of that. It really has no value until that other PR is merged and the ServiceControl PRs are released. |
|
@adamralph what @WilliamBZA said |
adamralph
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #774.
In the multi-instance mode, the retry command in ServiceControl master needs to be sent either to the local instance or one of the remotes in case the remote did handle the error.
Service Control newer versions of Service Control will return the instance id that can be passed back to ServiceControl. Based on the configured slave instances it then figures out to which instance it needs to send the message to. If the parameter is not present it always sends it to itself