Installer expects 'Users' group. Language specific.

[warcode]

In a non-English install of Windows 7 x64 I get the error "An error occurred while applying security settings. Users is not a valid user or group.", which is correct as it doesn't exist. All local groups are language specific. Manually creating the group skips the error but causes a nondescript error later. Install can't finish.

[gbiellem]

Looks like this code to localize the name in this custom action isn't working correctly when called from the installer

[johnsimons]

Could it be something to do with our msi being set to english ?
And maybe that causes the Culture in the .net code be set to english?

[johnsimons]

Or maybe we just use the sid ?

[gbiellem]

@johnsimons yep I had the same thoughts

[gbiellem]

SID not supported by netsh.exe - resorted to SDDL

[gbiellem]

The Custom Action was only one part of the problem, Advanced Installer stores reg and file permissions sets for wellknown groups in english rather that SIDs so the setting here are also killing the installer on foreign language OSes.
See https://github.com/Particular/ServicePulse/blob/master/installer/ServicePulse.aip#L396

[johnsimons]

That is going to be harder to fix!

[gbiellem]

This FAQ article seems to indicate that Advanced Installer should do the magic mapping of "Users" to the correct localized name.

I'll try a evaluation version of the latest version of Adv Installer to see if this makes difference, otherwise I'll add a custom action.

[gbiellem]

Verified that latest Adv Installer doesn't fix the issue - looks like custom actions are the way to go.

[gbiellem]

Fixed