Check supported SC version and report correct error

[dannycohen]

When SP tries to connect to a an SC version that does not support SP, it presents the following error message:

The expected behavior would be to check for the version of the SC instance it is trying to connect to, and make sure that version is equal to or later then an approved and tested version. If not - display an appropriate and informative message.

[indualagarsamy]

This is not an issue during production. What is happening here is if the Service Control is not available, then the alert message is displayed. All SP is trying to do is to connect to a URL.

[dannycohen]

This is not an issue during production.

It is an issue during production, although it may be phrased differently.

Let me ask you this: what would be Opie's experience when he as an SP instance trying to connect to an old / incompatible version of SC ?

• I would assume that at this moment he will receive a vague exception (e.g. a 404) that will make our lives a lot harder to debug the issue.
• What I am proposing is that when connecting to SC we add a check for the SC version (which is readily available) and make sure it is supported by the current SP version.
• The goal is to save us a lot of support effort by providing a better error description when connecting to an incompatible SC version.

IMO, We can either do it now, before the support headaches begin, or do it later, and suffer through the support headaches.

[johnsimons]

Agree, but lets update the description with just that.
Also I assume the version check is something like: SC version >= 1.0

On Wednesday, November 6, 2013, Danny Cohen wrote:

This is not an issue during production.

It is an issue during production, although it may be phrased differently.

Let me ask you this: what would be Opie's experience when he as an SP
instance trying to connect to an old / incompatible version of SC ?

• I would assume that at this moment he will receive a vague exception
  (e.g. a 404) that will make our lives a lot harder to debug the issue.
• What I am proposing is that when connecting to SC we add a check for
  the SC version (which is readily available) and make sure it is supported
  by the current SP version.
• The goal is to save us a lot of support effort by providing a better
  error description when connecting to an incompatible SC version.

IMO, We can either do it now, before the support headaches begin, or do it
later, and suffer through the support headaches.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-27866307
.

Regards
John Simons
NServiceBus

[dannycohen]

I assume the version check is something like: SC version >= 1.0

Yes, with "1.0" being defined in config.

[johnsimons]

Defined in config?
No need to define in config as this is not a configurable setting.

On Wednesday, November 6, 2013, Danny Cohen wrote:

I assume the version check is something like: SC version >= 1.0

Yes, with "1.0" being defined in config.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-27867359
.

Regards
John Simons
NServiceBus

[dannycohen]

Correct. Not configured by user, but set by us.

[johnsimons]

Yes, I do need to hardcoded it somewhere.

On Thursday, November 7, 2013, Danny Cohen wrote:

Correct. Not configured by user, but set by us.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-27871851
.

Regards
John Simons
NServiceBus

[andreasohlund]

Let's bump this to 1.0.0?

[dannycohen]

OK, but the more installations / versions are out there that do not support this, the more issues we will encounter.

[johnsimons]

Is this really required for v1?

[dannycohen]

@johnsimons - Lets discuss and evaluate.

[dannycohen]

@johnsimons / @indualagarsamy - Following a chat with @andreasohlund -

The issue can be minimized to show SP / SC versions in a prominent and avisible way.
For example, in SI the about page shows the following.

Do you want to have something similar for SC / SP ?

[johnsimons]

I see this as a nice to have, hence not required for v1

[dannycohen]

I'll leave it to you guys to decide, but consider how you will need to debug a customer issue that may (and probably will) require that you easily identify both SP and SC versions.

// CC @indualagarsamy

[andreasohlund]

How tricky is this to implement? (I agree with @dannycohen that the version
will very usefull when we start to get error reports from users)

On Mon, Feb 10, 2014 at 1:06 PM, Danny Cohen notifications@github.comwrote:

I'll leave it to you guys to decide, but consider how you will need to
debug a customer issue that may (and probably will) require that you easily
identify both SP and SC versions.

// CC @indualagarsamy https://github.com/indualagarsamy

Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-34624585
.

[dannycohen]

P.S.> SM also has an easy to locate feature for version detection.

[andreasohlund]

@johnsimons your take on this? bump or do it?

[johnsimons]

I assume you are asking about displaying the versions somewhere on the UI?

[andreasohlund]

Correct

On Wed, Feb 26, 2014 at 10:28 AM, John Simons notifications@github.comwrote:

I assume you are asking about displaying the versions somewhere on the UI?

Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-36106420
.

[johnsimons]

Displaying versions in the dashboard screen at the bottom: