The "Remove" button for an endpoint is not clear (both meaning and functionality) #70

dannycohen · 2013-11-21T09:09:59Z

What is it intended to do ?
Is it a partial implementation of #15 ?
(specifically item 2: "Clicking on the configuration indicator in the dashboard leads Opie to the endpoint configuration page")

(also - IMO - it looks bad...)

dannycohen · 2013-11-27T13:50:33Z

@andreasohlund / @johnsimons / @indualagarsamy -
Please address this for RC.

The implementation looks bad and is not coherent (at the very least, explain what its supposed to do...)

Note that the "mute" feature in Custom Checks is a better one (i.e. it looks good, has a good tooltip and is understandable). A similar ad-hoc implementation here would be much preferable to shipping this; if not - please remove this "Remove" button...

andreasohlund · 2013-11-27T14:54:17Z

Lets just remove the button? ( and perhaps fix the colors)

On Wed, Nov 27, 2013 at 2:50 PM, Danny Cohen notifications@github.comwrote:

@andreasohlund https://github.com/andreasohlund / @johnsimonshttps://github.com/johnsimons/
@indualagarsamy https://github.com/indualagarsamy -
Please address this for RC.

The implementation looks bad and is not coherent (at the very least,
explain what its supposed to do...)

Note that the "mute" feature in Custom Checks is a better one (i.e. it
looks good, has a good tooltip and is understandable). A similar ad-hoc
implementation here would be much preferable to shipping this; if not -
please remove this "Remove" button...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-29385293
.

dannycohen · 2013-11-27T15:01:17Z

Regarding Fix the colors - just use a similar pallete to what we have in Custom Checks

Regarding Removing the button - I'm fine with that, but we need an implementation of #15.
As I said above, this seems like a partial half-baked implementation of #15. Am I mistaken ?

indualagarsamy · 2013-11-27T16:27:24Z

Remove means, that endpoint will no longer be actively monitored. I intend to complete the styling of that page for RC. The idea is to display actively monitored endpoints, endpoints found but not monitored (things from the audit Q/error Q). Does that make sense?

dannycohen · 2013-11-27T17:14:03Z

To me. it sounds a lot like #15 (especially the monitor checkbox).
Can you explain the difference between the current implementation and #15 ?

Anyway - the current implementation does not work like that since after clicking "remove", if a heartbeat is received, the endpoint is re-monitored.

johnsimons · 2013-11-27T22:18:29Z

Sorry guys, I have all the intention of fixing that screen not just the button 😉
I just added it, it is a WIP.

dannycohen · 2013-11-27T22:21:23Z

@johnsimons - Fixing how ? what's the plan ? and what's the diff with #15 ?

andreasohlund · 2013-12-14T07:00:40Z

@indualagarsamy is working on this one!

dannycohen · 2013-12-14T08:49:16Z

cool!
@indualagarsamy - what's the plan ? and what's the diff with #15 ?

johnsimons · 2013-12-14T09:12:31Z

The plan is to provide the user with a way to decommission endpoints that
are no longer in use.
We need to skin this screen and make it look more like the "mute" in custom
alerts.
Regarding number 15, it is possible that overlaps.

On Saturday, 14 December 2013, Danny Cohen wrote:

cool!
@indualagarsamy https://github.com/indualagarsamy - what's the plan ?
and what's the diff with #15 #15?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563179
.

johnsimons · 2013-12-14T09:19:38Z

Btw, the decommissioning of an endpoint is quite a big task, we need to:

mute custom alerts
clear errors
clear heartbeats

On Saturday, 14 December 2013, Danny Cohen wrote:

cool!
@indualagarsamy https://github.com/indualagarsamy - what's the plan ?
and what's the diff with #15 #15?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563179
.

dannycohen · 2013-12-14T09:23:34Z

@johnsimons -

Btw, the decommissioning of an endpoint is quite a big task, we need to:

mute custom alerts

clear errors

clear heartbeats

I think de-commissioning an endpoint can be reduced to forward-looking monitoring only.
Existing custom alers / errors / heartbeats can be "muted" (or archived) manually and separately
(IMO - it can be done manually both because it is acceptable as a UX, and because it will reduced the work effort involved).

johnsimons · 2013-12-14T09:31:15Z

Have just read 15 :)
I like "stop monitoring" as the text for the button, since that is actually
all we doing, at least for now, thoughts?

On Saturday, 14 December 2013, Danny Cohen wrote:

@johnsimons https://github.com/johnsimons -

Btw, the decommissioning of an endpoint is quite a big task, we need to:

mute custom alerts

clear errors

clear heartbeats

I think de-commissioning an endpoint can be reduced to forward-looking
monitoring only.
Existing custom alers / errors / heartbeats can be "muted" (or archived)
manually and separately
(IMO - it can be done manually both because it is acceptable as a UX, and
because it will reduced the work effort involved).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563589
.

dannycohen · 2013-12-14T09:31:39Z

@johnsimons -

Regarding number 15, it is possible that overlaps.

In my view, it is important to be able not only to "mute" but also to "unmute" an endpoint instance.
I.e. the UI (and underlying implementation) should accept binary setting (turning an endpoint monitoring on/off).

johnsimons · 2013-12-14T09:33:00Z

Doing all three in a single action is trivial and IMO easier for the user.

On Saturday, 14 December 2013, Danny Cohen wrote:

@johnsimons https://github.com/johnsimons -

Btw, the decommissioning of an endpoint is quite a big task, we need to:

mute custom alerts

clear errors

clear heartbeats

I think de-commissioning an endpoint can be reduced to forward-looking
monitoring only.
Existing custom alers / errors / heartbeats can be "muted" (or archived)
manually and separately
(IMO - it can be done manually both because it is acceptable as a UX, and
because it will reduced the work effort involved).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563589
.

johnsimons · 2013-12-14T09:34:52Z

Should u display "stopped" endpoints in the same screen?

On Saturday, 14 December 2013, Danny Cohen wrote:

@johnsimons https://github.com/johnsimons -

Regarding number 15, it is possible that overlaps.

In my view, it is important to be able not only to "mute" but also to
"unmute" an endpoint instance.
I.e. the UI (and underlying implementation) should accept binary setting
(turning an endpoint monitoring on/off).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563695
.

dannycohen · 2013-12-14T09:38:59Z

Should u display "stopped" endpoints in the same screen?

I think that would be nice. If you make a sortable table in time - that would be great with that.

Doing all three in a single action is trivial and IMO easier for the user.

You just said it going to be "quite a big task"...

johnsimons · 2013-12-14T10:01:15Z

Lol, I meant non trivial!

On Saturday, 14 December 2013, Danny Cohen wrote:

Should u display "stopped" endpoints in the same screen?

I think that would be nice. If you make a sortable table in time - that
would be great with that.

Doing all three in a single action is trivial and IMO easier for the user.

You just said it going to be "quite a big task"...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30563799
.

dannycohen · 2013-12-14T10:15:04Z

So what is achievable in a reasonable amount of time & effort ?

indualagarsamy · 2013-12-14T14:58:53Z

I like "Stop Monitoring" as well. IMO we shouldn't be deleting history.
Removing all those alerts, would make it look like they never existed, which isn't true.

dannycohen · 2013-12-14T17:02:26Z

I like "Stop Monitoring" as well.

NP with "Stop Monitoring" as long as after clicking on it, we get "Start Monitoring" (or "Continue Monitoring")

IMO we shouldn't be deleting history.

Delete - of course not. "Soft delete" or "mute" - I think its acceptable, but lets start by not muting anything; user can mute manually.

andreasohlund · 2013-12-14T18:36:15Z

One thing that I've been mulling over:

In this case we're really looking at endpoint instances. Do we need another view for endpoints?

Another option is to make this view "group by endpoint"?

Sent from my iPhone

On 14 dec 2013, at 18:02, Danny Cohen notifications@github.com wrote:

I like "Stop Monitoring" as well.

NP with "Stop Monitoring" as long as after clicking on it, we get "Start Monitoring" (or "Continue Monitoring")

IMO we shouldn't be deleting history.

Delete - of course not. "Soft delete" or "mute" - I think its acceptable, but lets start by not muting anything; user can mute manually.

—
Reply to this email directly or view it on GitHub.

dannycohen · 2013-12-14T18:48:03Z

Do we need another view for endpoints?

I don't think so.

Another option is to make this view "group by endpoint"?

Yes, or "sort by endpoint" (which is what you can do based on #15 myBalsamiq design. I'd say this is nice to have, and good enough for start if we can do it fast.
In the future we may also want to "sort by Endpoint group" along the lines of Particular/ServiceInsight#150

andreasohlund · 2013-12-14T18:51:44Z

Should we then switch from /api/endpoints => /api/endpointinstances in
order to have a "placehodler" to provide a endpoint specific view in the
future

Eg.

/api/endpoints

[
{ id , Name, NumberOfMachines, TotalErrors, CurrentCriticalTime,
AllHeartbeatsOk, etc etc}
]

On Sat, Dec 14, 2013 at 7:48 PM, Danny Cohen notifications@github.comwrote:

Do we need another view for endpoints?

I don't think so.

Another option is to make this view "group by endpoint"?

Yes, or "sort by endpoint" (which is what you can do based on #15 https://github.com/Particular/ServicePulse/issues/15myBalsamiq design. I'd say this is nice to have, and good enough for start
if we can do it fast.
In the future we may also want to "sort by Endpoint group" along the lines
of Particular/ServiceInsight#150 Particular/ServiceInsight#150

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-30583150
.

dannycohen · 2013-12-14T19:02:31Z

Should we then switch from /api/endpoints => /api/endpointinstances

I don't see a real need, and currently its too much of a change for too little potential future value (if any).

IMO - If we need this sort of grouping we can have a separate /api/statistics or /api/endpoint/statistics etc.

indualagarsamy · 2014-01-11T07:40:44Z

Going to remove the "Remove" button on this page.
We are going to rework this page to show the active and the inactive endpoints with the last received hearbeat information.
Closing this issue, since we have different issues that track the feature / requirement.

dannycohen · 2014-01-11T11:18:50Z

Closing this issue, since we have different issues that track the feature / requirement

What other issues should I be tracking ? Is it #15 ?

indualagarsamy · 2014-01-11T12:12:18Z

Yes. Does that sound ok to you?

dannycohen · 2014-01-11T14:20:25Z

Yup, we just need to make sure everything on #15 make sense to you.
On #15 - I am not sure issue 1 should be done as-is. Issue 2 makes sense.

ghost assigned andreasohlund Nov 27, 2013

ghost assigned indualagarsamy Dec 14, 2013

ghost assigned johnsimons and indualagarsamy Dec 15, 2013

indualagarsamy closed this as completed Jan 11, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The "Remove" button for an endpoint is not clear (both meaning and functionality) #70

The "Remove" button for an endpoint is not clear (both meaning and functionality) #70

dannycohen commented Nov 21, 2013

dannycohen commented Nov 27, 2013

andreasohlund commented Nov 27, 2013

dannycohen commented Nov 27, 2013

indualagarsamy commented Nov 27, 2013

dannycohen commented Nov 27, 2013

johnsimons commented Nov 27, 2013

dannycohen commented Nov 27, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

indualagarsamy commented Dec 14, 2013

dannycohen commented Dec 14, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

indualagarsamy commented Jan 11, 2014

dannycohen commented Jan 11, 2014

indualagarsamy commented Jan 11, 2014

dannycohen commented Jan 11, 2014

The "Remove" button for an endpoint is not clear (both meaning and functionality) #70

The "Remove" button for an endpoint is not clear (both meaning and functionality) #70

Comments

dannycohen commented Nov 21, 2013

dannycohen commented Nov 27, 2013

andreasohlund commented Nov 27, 2013

dannycohen commented Nov 27, 2013

indualagarsamy commented Nov 27, 2013

dannycohen commented Nov 27, 2013

johnsimons commented Nov 27, 2013

dannycohen commented Nov 27, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

johnsimons commented Dec 14, 2013

dannycohen commented Dec 14, 2013

indualagarsamy commented Dec 14, 2013

dannycohen commented Dec 14, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

andreasohlund commented Dec 14, 2013

dannycohen commented Dec 14, 2013

indualagarsamy commented Jan 11, 2014

dannycohen commented Jan 11, 2014

indualagarsamy commented Jan 11, 2014

dannycohen commented Jan 11, 2014