Support Archiving of Failed Messages

[dannycohen]

As Opie, I want to be able to remove failed messages that cannot be successfully retried from the SP display (both Failed Messages Events page and the Dashboard).

Notes

1. This replaces Implement events acknowledgement #13 for Failed Messages
2. User feedback quote:

...regarding the Failed Messages. In my case I have a lot of failed messages which there is no point to retry. These messages will never be successful. What I want to do is to delete these. Is this something that you might consider to implement in the tool?

Visualization

1. In the Failed Messages events page add an "Archive Selected"
2. Clicking any of these buttons raises a warning messages: "All selected failed messages will be archived and will not be available for Retry. Are you sure you want to continue ?"
3. After approval, all selected failed messages are send for archiving in SC
   • Archiving is SC is a soft delete, i.e:
     • the message is marked as archived
     • the message data (body, headers, history) is not physically deleted from the database
     • it is still possible to retrieve (via direct RavenDB access) the archived message
     • the fact that the message was archived, and the archiving timestamp are added to the message data
4. SP UI is updated as follows:
   • In Failed Message Events list page:
     1. Archived failed messages are removed
     2. The "Total Number" and 'Summary Statistics" are updated following the failed messages removal
   • In Dashboard:
     • Failed Messages indicator count is updated to indicate the up-to-date number of failed messages after the sending of the failed messages for archiving

[andreasohlund]

@nulltoken can you take a look at this one?

[nulltoken]

@nulltoken can you take a look at this one?

👍 I'm on it

[dannycohen]

@nulltoken - Thanks!

Note that the "archiving" of a failed message will also have implications on ServiceInsight (i.e. a failed message archived in SP will also be hidden in SI) and some implications on future features related to archiving and statistics of failed messages.

Please add a comment to this GH issue specifying the stored data format changes related to archiving a failed message so we can review and align the other tools / features.

// CC @HEskandari

[dannycohen]

Note regarding "Archived failed messages are removed from events page"

The archived failed messages can be either removed or (more preferably) behave like the retry feature, i.e. each archived failed message is marked as "archived" and is no long selectable for any action.

See implementation for "retried" messages below:

[andreasohlund]

@nulltoken while looking at how we can do this I've found the need for a few refactorings before we can tackle this. I'll ping you when those are done. So this one is on hold for now. Please look at the GFV issues in the meantime

[nulltoken]

@andreasohlund Sir, yes Sir! 😉

[dannycohen]

@johnsimons / @indualagarsamy / @andreasohlund -
Summarising discussion with @andreasohlund -

1. There's no need (for this refresh) for an "Archive all" button
2. The messages for archiving will be selected one by one and a click on "Archive Selected" (similar behavior / UI language to "Retry Selected")
3. In a future release we will be adding a "select all" checkbox that will resolve the corner cases of archiving / retry all messges displayed on the screen.

[johnsimons]

Can this go into v2?

[dannycohen]

Can this go into v2?

No.
We got @udidahan approval for delays if necessary.
What's your analysis ?

[andreasohlund]

This is trivial with our new storage model. I'll do it tomorrow

On Mon, Dec 16, 2013 at 12:48 PM, Danny Cohen notifications@github.comwrote:

Can this go into v2?

No.
We got @udidahan https://github.com/udidahan approval for delays if
necessary.
What's your analysis ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/73#issuecomment-30654753
.

[johnsimons]

Famous last words!

On Monday, 16 December 2013, Andreas Öhlund wrote:

This is trivial with our new storage model. I'll do it tomorrow

On Mon, Dec 16, 2013 at 12:48 PM, Danny Cohen <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

Can this go into v2?

No.
We got @udidahan https://github.com/udidahan approval for delays if
necessary.
What's your analysis ?

—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/ServicePulse/issues/73#issuecomment-30654753>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/73#issuecomment-30656421
.

[andreasohlund]

:)

On Mon, Dec 16, 2013 at 7:34 PM, John Simons notifications@github.comwrote:

Famous last words!

On Monday, 16 December 2013, Andreas Öhlund wrote:

This is trivial with our new storage model. I'll do it tomorrow

On Mon, Dec 16, 2013 at 12:48 PM, Danny Cohen <notifications@github.com<javascript:_e({},
'cvml', 'notifications@github.com');>>wrote:

Can this go into v2?

No.
We got @udidahan https://github.com/udidahan approval for delays if
necessary.
What's your analysis ?

—
Reply to this email directly or view it on GitHub<

https://github.com/Particular/ServicePulse/issues/73#issuecomment-30654753>

.

—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/ServicePulse/issues/73#issuecomment-30656421>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/73#issuecomment-30686713
.